Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve stackoverflow theme integration #35

Merged
merged 168 commits into from
Dec 14, 2023
Merged

Feature/improve stackoverflow theme integration #35

merged 168 commits into from
Dec 14, 2023

Conversation

levino
Copy link
Collaborator

@levino levino commented Nov 29, 2023 •
edited by coderabbitai bot

Summary by CodeRabbit

  • New Features

    • Implemented a new ESLint configuration for improved code quality.
    • Added GitHub Actions workflow updates including Node.js version bump and Slack notifications for releases.
    • Introduced Storybook configuration enhancements for better component documentation.
    • Launched internationalization support with i18next for Storybook.
    • Created new React components for displaying various sections of a resume, such as Awards, Certificates, Education, Interests, Languages, Projects, Publications, References, and Skills.
    • Added Storybook stories for newly created components to visualize component states.
    • Updated theme README with information about the new jsonresume-theme-stackoverflow-react.
    • Enhanced CSS styling for better visual presentation across devices.

  • Bug Fixes

    • Addressed design regressions and improved layout consistency.
    • Fixed issues with file reduction for npm publication.

  • Documentation

    • Updated CHANGELOG with recent updates, bug fixes, and new features.
    • Improved documentation for the new theme and its usage.

  • Refactor

    • Streamlined components and stories for better modularity and maintainability.

  • Style

    • Applied comprehensive style updates to ensure a modern and responsive design.

  • Chores

    • Adjusted .gitignore and .npmignore configurations for cleaner repository management.
    • Updated .yarnrc.yml for Yarn configuration consistency.

  • Tests

    • Added basic test configurations for CI.

Please note that internal code-level details are intentionally omitted to maintain confidentiality.

Francesco Esposito and others added 30 commits September 7, 2015 17:07
Documentation
c589f02
README update
28bc98b
momentjs bug fixed
4c77c5e
momentjs bug fixed
4ffc811
v0.1.1
1d96d98
added location to work and education
82f01aa
added place of birth
ac6f6a9
added place of bird
2679f96
Delete index.html
a2e5ef4
Delete _resume.json
d24aad8
style improvements
381bd6f
style improved
4a96253
added .gitignore
d7471d6
updated depencies and bug fixing
cb2eb2c
version 1.0.0 released
2498adc
Delete script.js
20cef2c
hotfix date error (always january of a given year))
128c487
setting version to 1.0.1
569dd8f
add support to manage birth data
f96e55a
Merge pull request #2 from mrbabbs/bug/manage-birth-data
fde7b29 
add support to manage birth data
hide birth tag if birth object is empty
2c0b52d
avoid to add comma when birth.state is populated
ab5a8ef
Merge pull request #3 from mrbabbs/bug/manage-birth-data
e4753ed 
Bug/manage birth data
Fixes typo for interests' summary
325190e
Merge pull request #4 from mfukar/master
47a7473 
Fixes typo for interests' summary
Prevent word breaks in very long lines
2601959 
Since word breaks are not shown with a hyphen, this behaviour leads to a
sloppy-looking CV.
Merge pull request #5 from mfukar/master
6b1b28b 
Prevent word breaks in very long lines
@mfukar
Add a space in ::before separators (#6)
fd8d775
fixed issue #9 on interest summary
ad80f57
Merge branch 'master' of https://github.com/francescoes/jsonresume-th…
8e422d5 
…eme-stackoverflow
thomasdavis
thomasdavis approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@thomasdavis thomasdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
https://jsonresume-org-registry-ciyujqrbt-jsonresume.vercel.app/thomasdavis?theme=stackoverflow

@levino
Copy link
Collaborator Author

levino commented Dec 5, 2023

I will try to clean up the git history. Also I want to enable deployment to npm from ci, so I do not have to do it by hand.

@thomasdavis
Copy link
Member

oh npm deployment would be hot. trigged by package.json version changes or something else?

@levino levino mentioned this pull request Dec 9, 2023
Open
@levino levino force-pushed the feature/improve-stackoverflow-theme-integration branch from 16c9239 to b5553dd Compare December 14, 2023 09:04
@levino levino force-pushed the feature/improve-stackoverflow-theme-integration branch from b5553dd to d165e44 Compare December 14, 2023 09:10
@levino levino marked this pull request as ready for review December 14, 2023 09:14
@levino levino force-pushed the feature/improve-stackoverflow-theme-integration branch from d165e44 to b0a714e Compare December 14, 2023 09:14
@levino levino added this pull request to the merge queue Dec 14, 2023
@levino
Copy link
Collaborator Author

levino commented Dec 14, 2023

Merging. Any fallout from this I will mop up later.

Merged via the queue into master with commit 3458648 Dec 14, 2023
7 checks passed
@levino levino deleted the feature/improve-stackoverflow-theme-integration branch December 14, 2023 09:23
@thomasdavis
Copy link
Member

@levino so good to have the stackoverflow theme back, great job

@levino levino mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasdavis thomasdavis thomasdavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet