Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Bump minyma theme version to 0.0.4 #56

Closed
wants to merge 3 commits into from

Conversation

godraadam
Copy link
Contributor

To address Vercel's edge runtime not supporting fs.readFileSync I simply inlined the markup template string in the theme, and bumped the version number accorsingly to 0.0.3 in apps/registry/package.json.

Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: 4810e1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 0:08am
jsonresume-org-registry ❌ Failed (Inspect) Dec 8, 2023 0:08am

Copy link

vercel bot commented Dec 8, 2023

@godraadam is attempting to deploy a commit to the JSON Resume Team on Vercel.

A member of the Team first needs to authorize it.

@godraadam godraadam changed the title Bump minyma theme version to 0.0.3 Feature/Bump minyma theme version to 0.0.3 Dec 8, 2023
@thomasdavis
Copy link
Member

@godraadam something is wrong with the frozen lock file so I just created another PR to update it.

#57

And thanks for updating that. I know it sucks, and I am trying to figure out a work around. fs.readFileSync does work, but it is not "working" when in combination with turbo repo. The file doesn't exist because the vercel bundling refuses to include those css/partials.

But thanks again, will ping you when I finally figure it out.

@godraadam godraadam changed the title Feature/Bump minyma theme version to 0.0.3 Feature/Bump minyma theme version to 0.0.4 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants