Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export pdf get package theme from local context #673

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

davcd
Copy link
Contributor

@davcd davcd commented Feb 14, 2022

As discussed in #408 this fix will calculate the theme package from the local context instead the global one.
This will align the calculation of the theme package path, although in the future it will be interesting to unify every theme package access.
With these changes it will be possible to use:

npm install jsonresume-theme-my-theme
resume export resume.pdf --format pdf --theme my-theme
resume export resume.html --format html --theme my-theme

@davcd davcd changed the title fix: export pdf get package theme from local fix: export pdf get package theme from local context Feb 14, 2022
@thomasdavis thomasdavis merged commit 0bb921e into jsonresume:master Feb 15, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants