-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why both "state" and "region" and not "province", "oblast", etc..? #19
Comments
I thought state and region were the only ones used, but I guess that was naive. It's just hard to theme when the property names are dynamic. Because templates might print {{state}} or {{region}}, if someone could chime in with some abstract term which might represent all that would be great. Otherwise we might have to roll with each possibility (state,region,oblast,province) |
Yuck. I'd go with:
Where regionType would be free form, but with a couple of common suggestions. |
ahh it's been a long day, your suggestion is great. On Mon, Jul 7, 2014 at 6:51 PM, Walter Doekes notifications@github.com
Thomas Davis VP of Tech - Earbits - http://earbits.com |
Long day? As a non-American, I find that it's still morning ;-) Jokes aside, thanks for the positive response! |
Most people do not need to have their region type specified. A form like PS. |
I second what @Kwpolska says, with regards to region. I don't think a With regards to |
I tried As for the However, there is the risk of people using 'region' as an actual region, so you cannot reliably use to filter on. For example, if I live near Amsterdam (capital of NL), I could put various in things there:
We could just accept that filtering by region may prove difficult, and leave it up to the author of the resume to specify the most sensible value there. |
I totally agree on not using An option for |
But then again, no matter which of those we choose, sorting is still impossible. There are tons of ways to refer to a thing:
And then we get out of our US-centric bubble, to eg. Wrocław, Poland, which we can say:
There are also two, more unlikely options, to use Śląsk/Silesia, which may anger some people, and that would be generally used for Upper Silesia instead. One might also use the term province. Or, be even more hardcore: require the ISO 3166-2 codes (the format is: |
That's why I think we should stick to region and let the author of the resume figure out what s/he wants to put there. We cannot possible please everyone/satisfy every possible condition. |
#12 geotagging makes the whole sorting/filtering point moot. |
👍 to geotagging |
City sounds like it will stay Geotagging is great and seemingly solves all the problems but I'm not sure it makes to push as the standard way to begin with. The theming systems will obviously have to have a geo lookup built into them so maybe it makes more sense to push for geo tagging when that functionality gets built out. For the sake of simplicity, it sounds like a good idea to either settle with either Region or State. I don't know enough about websites who use Region but State does seem pretty global even though it's not correct for some countries. |
Maybe we should just let people who live in a state put |
+1 to keeping only "state" for the v1 version |
@vote539, this sounds quite impossible. The |
As an American who lives in Germany, I prefer "region" because a state is also a region within the US. |
What about this then? #79 |
Build does not pass, please revisit. |
I still think we should pick one ("region" has my preference as well) and stick with that for the time being. That means that #79 would be obsolete. |
+1 for "region", and simplicity for v1. Can always revisit. |
Experimenting with a new label called "Decision Needed", this issue has it applied. It means we will be passing something through in the very near future. |
I feel like flipping a coin on this one, hard decision.
Maybe we will change the culture of the world and region will become prominent everywhere e.g. The United Regions of America |
I created the above PR to fix this. |
Issue resolved and added to Changelog |
Create validator
As a non-American, I find it strange why there would be two ways to specify a region when neither of them applies to the Dutch "province" or the Swedish "landskap" (or "län") or "oblast".
Can't you just remove "state" and add this to the description: "Americans put state in the region field. Others may put region or province or whatever seems most likely for their country there."
The text was updated successfully, but these errors were encountered: