Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resume serve shows local theme, but resume export shows 'flat' #298

Closed
vanhoutenbos opened this issue Jan 4, 2019 · 11 comments
Closed

resume serve shows local theme, but resume export shows 'flat' #298

vanhoutenbos opened this issue Jan 4, 2019 · 11 comments

Comments

@vanhoutenbos
Copy link

When I run resume serve I see my self designed resume with styling and everything,
but as soon as i run resume export it will show me the flat version, both in .html and .pdf.

@randytarampi
Copy link
Collaborator

Are you passing a --theme parameter?

Try resume export resume.pdf --format pdf --theme elegant, replacing elegant with foo for a particular jsonresume-theme-foo.

@vanhoutenbos
Copy link
Author

Yes I am indeed, when i add the foo paramater the following is my error messages:

To publish your resume at https://jsonresume.org type the command resume publish
{ TimeoutError: Navigation Timeout Exceeded: 30000ms exceeded
    at Promise.then (C:\Users\bar\Documents\GitHub\node_modules_test\resume-cli\node_modules\puppeteer\lib\FrameManager.js:1276:21)
  -- ASYNC --
    at Frame.<anonymous> (C:\Users\bar\Documents\GitHub\node_modules_test\resume-cli\node_modules\puppeteer\lib\helper.js:144:27)
    at Page.setContent (C:\Users\bar\Documents\GitHub\node_modules_test\resume-cli\node_modules\puppeteer\lib\Page.js:615:42)
    at Page.<anonymous> (C:\Users\bar\Documents\GitHub\node_modules_test\resume-cli\node_modules\puppeteer\lib\helper.js:145:23)
    at C:\Users\bar\Documents\GitHub\node_modules_test\resume-cli\lib\export-resume\index.js:105:16
    at process.internalTickCallback (internal/process/next_tick.js:77:7) name: 'TimeoutError' } '`createPdf` errored out'

Done! Find your new .pdf resume at:
 C:\Users\bar\Documents\GitHub\jsonresume-theme-partech\resume.pdf

@siddharthst
Copy link

Same problem. Simply git clone <customtheme> and then using it is not possible. I can see it using serve but not really export it.

@sambP
Copy link

sambP commented Mar 4, 2020

Why is the export command not using my local theme? How could I use my local theme without to publish it?

Even after I published it to the npm registry, it is not possible to use it. I get this error: Theme not supported please visit -> jsonresume/theme-functions#12

@sambP
Copy link

sambP commented Mar 4, 2020

@randytarampi why should he pass a theme? It should simple use the local theme. Exact like the serve command.

@rkt2spc
Copy link

rkt2spc commented May 27, 2020

Can we allow "." as theme name so it can be require('.') as a local theme package during development @thomasdavis
https://github.com/jsonresume/resume-cli/blob/master/lib/export-resume/index.js#L17

var theme = program.theme;
if (!theme.match('jsonresume-theme-.*') && theme != '.'){
    theme = 'jsonresume-theme-' + theme;
}

@thomasdavis
Copy link
Member

@rocketspacer If you run resume serve in your local theme folder it should serve it up, let me know if it doesn't

@RomRider
Copy link

RomRider commented Jun 3, 2020

@rocketspacer in https://github.com/jsonresume/resume-cli/blob/master/lib/export-resume/index.js#L17
Change it to:

  if (!theme.match('jsonresume-theme-.*') && theme != '.') {
    theme = 'jsonresume-theme-' + theme;
  } else if (theme === '.') {
    theme = `${process.env.PWD}`;
  }

And then --theme . works

@thomasdavis
Copy link
Member

I will on getting rendering local theme folders working.

@RomRider
Copy link

Is that already in place for this issue to be closed?

@thomasdavis
Copy link
Member

Sorry I forgot to link the other issues relating to it.

But I just pushed up 2.1.1 which now allows as you suggested for --theme . or -theme ../some/other/dir

Thanks for the patience

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants