Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rust with rust2 entry in index.jade #256

Closed
wants to merge 1 commit into from
Closed

Replace rust with rust2 entry in index.jade #256

wants to merge 1 commit into from

Conversation

dermesser
Copy link

The library in rust.jade, https://github.com/GildedHonour/frank_jwt, is of horribly low quality:

  • commit descriptions are lacking
  • error handling is not present and panics on every error, i.e. not suitable for anything more than very basic prototyping
  • library is very inflexible, e.g. relies on files to read keys from (instead of allowing arbitrary sources).

In contrast, the library in rust2.jade is of much higher quality (even on first sight), but hasn't been included yet. I urge you to accept this request, as including bad libraries like frank_jwt harms your (and everyone's) cause here.

The library in rust.jade, https://github.com/GildedHonour/frank_jwt, is of horribly low quality:

* commit descriptions are lacking
* error handling is not present and panics on every error, i.e. not suitable for anything more than very basic prototyping
* library is very inflexible, e.g. relies on files to read keys from (instead of allowing arbitrary sources).

In contrast, the library in rust2.jade is of much higher quality (even on first sight), but hasn't been included yet. I urge you to accept this request, as including bad libraries like frank_jwt harms your (and everyone's) cause here.
@sebadoom sebadoom self-requested a review November 17, 2017 19:39
@sebadoom sebadoom self-assigned this Nov 17, 2017
@sebadoom
Copy link
Contributor

sebadoom commented Dec 4, 2017

Other Rust libraries have been added to the list, including the one you mentioned. Unfortunately we still don't have a clear admission process for libraries in the list. Once this is in place we will enforce certain quality requirements for libraries to remain in the list.

Tracked by #279 and #277.

@sebadoom sebadoom closed this Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants