Added warning that module names exist in URL space #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning that module names exist in URL space, so should be / separated. In reference to systemjs/builder#814.
aluanhaddad
reviewed
Oct 18, 2017
| ``` | ||
| jspm bundle app/main build.js | ||
| ``` | ||
|
|
||
| Creates a file `build.js` containing `app/main` and all its dependencies referenced in config.js. | ||
| Creates a file `build.js` containing `app/main` and all its dependencies referenced in config.js. \ |
There was a problem hiding this comment.
To force a newline! I guess what happens is that in my editor, md renders differently from github (despite being set for gfm). It should be trivial enough for you to fix :)
aluanhaddad
reviewed
Oct 18, 2017
aluanhaddad
reviewed
Oct 27, 2017
| @@ -6,11 +6,12 @@ There are three main workflows for production: | |||
|
|
|||
| ### Creating a Bundle | |||
|
|
|||
| ***Important**: The module names such as `app/main` used in the examples below should only be `/` separated (On Windows, do NOT use `\` as your path separator for this argument). The module names are specified in URL space; in particular, they are not file-paths.* | |||
There was a problem hiding this comment.
I think this should be reworded slightly. It should say something closer to what the title of this PR says. Also, I think Note: would be better than Important.
|
I don't mind rewording as long as users are not confused about it (like I
was)...
…On 27 October 2017 at 19:15, Aluan Haddad ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/production-workflows.md
<#2322 (comment)>:
> @@ -6,11 +6,12 @@ There are three main workflows for production:
### Creating a Bundle
+***Important**: The module names such as `app/main` used in the examples below should only be `/` separated (On Windows, do NOT use `\` as your path separator for this argument). The module names are specified in URL space; in particular, they are not file-paths.*
I think this should be reworded slightly. It should say something closer
to what the title of this PR says. Also, I think *Note*: would be better
than *Important*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2322 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AClLM0wFJmIaZS5gTrVg1U0wycHN3FMCks5swd5kgaJpZM4OIQXj>
.
|
|
Agreed. |
aluanhaddad
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning that module names exist in URL space, so should be / separated. In reference to systemjs/builder#814.