Update listener tests according to CacheEntryEvent.getOldValue spec clarifications #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionErrors Also update CacheListenerTest as parametric test to assert old value availability when old value required is true or false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes client-server listeners test infrastructure to propagate AssertionErrors. Otherwise assertions from
CacheEntryListeners are silently swallowed.Also updates CacheListenerTest as parameterized test to assert old value availability when old value required is
trueorfalse.Depends on jsr107/jsr107spec#392 , part of fix for jsr107/jsr107spec#391