Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "'" (apostrophe) escaping #30

Merged
merged 1 commit into from
Jan 18, 2018
Merged

fix "'" (apostrophe) escaping #30

merged 1 commit into from
Jan 18, 2018

Conversation

bjrmatos
Copy link
Collaborator

a fix for #29

not sure if this is going to break anything or if the &#39 numeric character for ' ever worked, but it looks like all numeric characters that we need to use should be in hexadecimal, so i'm just changing ' to hex form -> '

@bjrmatos bjrmatos requested a review from pofider January 17, 2018 16:14
@pofider
Copy link
Contributor

pofider commented Jan 18, 2018

Hm. Seems you are right. Thank you.

@pofider pofider merged commit bacdc2e into master Jan 18, 2018
@pofider
Copy link
Contributor

pofider commented Jan 18, 2018

Does this solve #29 ? I would publish a new version then.

@bjrmatos
Copy link
Collaborator Author

@pofider yes, it solves it 👍

@bjrmatos bjrmatos deleted the escape-apostrophe branch March 12, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants