Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check of E-Mail address case insensitive #146

Closed
Hobby-Student opened this issue Jun 11, 2015 · 3 comments
Closed

make check of E-Mail address case insensitive #146

Hobby-Student opened this issue Jun 11, 2015 · 3 comments
Labels
bug Something isn't working

Comments

@Hobby-Student
Copy link

Sorry for disturbing again. ;)
Don't have time to make a pull request, but my suggestion has just few chars...

I would change the following in "GetCmsRecipient":

from

...
if (certificate.GetSubjectEmailAddress() == mailbox.Address)
...

to

...
if (certificate.GetSubjectEmailAddress().ToLower() == mailbox.Address.ToLower())
...

I don't think that E-Mail addresses are somewhere case sensitive...

@jstedfast
Copy link
Owner

The problem is that the local-part (the part before the @) is server dependent. However, domains can be treated as case insensitive.

jstedfast added a commit that referenced this issue Jun 11, 2015
@jstedfast
Copy link
Owner

N/m, it looks like I was already using case-insensitive comparisons everywhere except TemporarySecureMimeContext and WindowsSecureMimeContext, so I've fixed these up to do the same.

@jstedfast jstedfast added the bug Something isn't working label Jun 14, 2015
@jstedfast
Copy link
Owner

Just released 1.2.4 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants