Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKIM-Signature with trailing semi-colon #166

Closed
breedbekkikker opened this issue Aug 20, 2015 · 2 comments
Closed

DKIM-Signature with trailing semi-colon #166

breedbekkikker opened this issue Aug 20, 2015 · 2 comments
Labels
bug Something isn't working

Comments

@breedbekkikker
Copy link

ParseDkimSignature throws a format exception if the DKIM-Signature tag-list ends with a semi-colon.

The semi-colon is optional at the end of the tag-list, see https://tools.ietf.org/html/rfc6376#section-3.2

Example DKIM-Signature with a trailing semi-colon: https://tools.ietf.org/html/rfc6376#appendix-A.2

@jstedfast jstedfast added the bug Something isn't working label Aug 20, 2015
@jstedfast
Copy link
Owner

fixed

@breedbekkikker
Copy link
Author

Thanks for your prompt response!

Now that ParseDkimSignature continues while using a DKIM-Signature with a trailing semi-colon, GetSignedDkimSignatureHeader throws a format exception stating that the "signature parameter is not at the end".
When using a DKIM-Signature with a trailing semi-colon, GetSignedDkimSignatureHeader should return the DKIM-Signature without the b= signature tag value but WITH the trailing semi-colon.
Additionally, RFC does not state that the b= signature tag must be at end (although this would probably be the case in most implementations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants