Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetStandard2.0 optimizations #475

Closed
sebastienros opened this issue Mar 28, 2019 · 5 comments
Closed

NetStandard2.0 optimizations #475

sebastienros opened this issue Mar 28, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@sebastienros
Copy link

MimeKit target netstandard 2.0 but the csproj should not reference the assemblies it does right now with this target. Only Bouncy should still be necessary but it looks like this other ones are not. This would make the dependency graph smaller when using it from an app targeting netcoreapp2.0.

I can work on a PR if you agree.

@jstedfast
Copy link
Owner

Yea, I've known about this for a bit but haven't gotten around to fixing it. Thanks!

@jstedfast
Copy link
Owner

Do you have an idea of when you might have something ready? Just trying to plan out when to make the next release.

@sebastienros
Copy link
Author

Are the pull requests going through CI for each target? If so they I don't need to run the tests myself

@jstedfast
Copy link
Owner

No, they only test 4.5

@sebastienros
Copy link
Author

At least it will build the project, so it would just fail if there were issues. Will try today.

@jstedfast jstedfast added the enhancement New feature or request label May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants