Potentially fix CMS Data Envelope creation for ECC certificates #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
commented
Feb 8, 2024
cipherboy
commented
Feb 8, 2024
jstedfast
reviewed
Feb 8, 2024
This generates an ephemeral EC-DH key pair for KeyAgreement within the context of the CMS data envelope, using the same underlying curve as the recipient's certificate. Signed-off-by: Alexander Scheel <alexander.scheel@keyfactor.com>
cipherboy
force-pushed
the
potentially-fix-cms-creation-for-ecc
branch
from
6b0bd49
to
f124ef4
Compare
Signed-off-by: Alexander Scheel <alexander.scheel@keyfactor.com>
|
@jstedfast I think this version should retain compatibility with the existing OAEP selection code, but let you do ECC perhaps. I'll need a PR for BC-CSharp to do OAEP nicely, but you'll probably have to wait a bit to get a new release of that cut, so I'd probably suggest merging this as-is. :-) |
|
@cipherboy thanks a ton for your help, this is awesome. Give me a ping if you ever add that nicer way to do OAEP nicely, but if not, no worries - I don't mind having code that does a bit of extra work to massage things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment here for information: bcgit/bc-csharp#516 (comment)
Related: #998