Modified Rfc2047's internal Token class to be a struct #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the number of allocations needed, but it does mean that List<Token> will be much larger. To combat this a bit, redesigned the Token class/struct to have fewer fields which reduced sizeof(Token) from 40 bytes down to 24. Ideally, we'd get that down even further to 16 bytes (as recommended by Microsoft). Added some comments with ideas on how to accomplish that.
Makes use of ArrayPools to minimize allocations of the internal array as well. This should further reduce memory allocations when decoding headers.
|
I'm thinking that a better approach might be to have a Rfc2047TokenDecoder class/struct that is essentially a state machine that we can incrementally |
|
This idea has been replaced by #952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of allocations needed, but it does mean that List will be much larger.
To combat this a bit, redesigned the Token class/struct to have fewer fields which reduced sizeof(Token) from 40 bytes down to 24.
Ideally, we'd get that down even further to 16 bytes (as recommended by Microsoft). Added some comments with ideas on how to accomplish that.