Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser gojson incompatibility with go test's -coverprofile flag #134

Closed
forsaken628 opened this issue Jun 11, 2022 · 6 comments
Closed

Parser gojson incompatibility with go test's -coverprofile flag #134

forsaken628 opened this issue Jun 11, 2022 · 6 comments
Assignees
Labels

Comments

@forsaken628
Copy link

forsaken628 commented Jun 11, 2022

When handle
yy.txt

Generated report contain incorrect content like this

<testcase name="TestSrv_ServiceMap" classname="example.com/foo/pkg/labels" time="0.000">
	<error message="No test result found"></error>
</testcase>

command:
go test -json -race -coverpkg=./... -covermode=atomic -coverprofile=out/cover.out.tmp ./...

go version:
go 1.18

@jstemmer jstemmer added the bug label Jun 11, 2022
@jstemmer
Copy link
Owner

Thanks. It looks like the testcase gets attributed to the wrong package, possibly because of the order in which it appears in the output.

I don't think I've seen this before, it would be helpful if I could reproduce this output somehow. Can you share a bit more about the environment and the tests that you ran, e.g. what version of Go did you use and did you run any tests in parallel? Did you use any additional commandline options when running go test?

@medzin
Copy link

medzin commented Jul 15, 2022

I can confirm that I have a similar issue regardless of whether I'm using a test coverage reporting or not. After disabling the test report in JSON, the tests run stably.

@jstemmer
Copy link
Owner

I managed to reproduce by testing multiple packages at a time and enabling the race detector (-race). For non-JSON output, test events are always grouped by package. When enabling JSON output this appears to not always be the case, test events from different packages may be mixed occasionally which triggers the bug you observed. Fortunately, each event in the JSON output contains the package name so this is fixable but it will require some refactoring.

Until this has been fixed you can work around this problem by disabling the race detector, or not use the JSON test output.

@jstemmer jstemmer self-assigned this Jul 20, 2022
jstemmer added a commit that referenced this issue Aug 15, 2022
The reportBuilder assumed we were always processing events for a single
package at a time. This is not true however when running `go test -json
-race` for example. In order to properly support processing events from
different packages we now have packageBuilders per package name.

Fixes #134
jstemmer added a commit that referenced this issue Aug 15, 2022
jstemmer added a commit that referenced this issue Aug 15, 2022
@karelbilek
Copy link

I have been hit by the same bug now. Yes this is fixable by looking at the JSON tag.

I can have a look at this and make a PR

@karelbilek
Copy link

Ah, seems like we were using stable 2.0.0 version, which doesn't have this fixed, that's the reason. Nevermind!

@altego371
Copy link

FYI
If you are using a version without this fix you can use the next trick:
go test -json [...] | jq -c '{k: .Package, v: .}' | sort | jq -c '.v' | go-junit-report [...] where [...] are yours flags
It sorts go test output before passing it to the go-junit-report.
jq https://stedolan.github.io/ is a cli-tool for json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants