Rewritten overly complicated condition

jstirk · Aug 7, 2011 · 8886548 · 8886548
1 parent 4f20905
commit 8886548
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/views/shared/_review.html.erb b/app/views/shared/_review.html.erb
@@ -12,7 +12,7 @@
   <span class="attribution"><%= t('submitted_on') %> <strong><%= l review.created_at.to_date %></strong></span>
 
   <%= simple_format(review.review) %>
-  <% if Spree::Reviews::Config[:feedback_rating] && ((Spree::Reviews::Config[:require_login] && current_user) || !Spree::Reviews::Config[:require_login]) %>
+  <% if Spree::Reviews::Config[:feedback_rating] && (!Spree::Reviews::Config[:require_login] || current_user) %>
   <div class="feedback_review" id="feedback_review_<%= review.id %>">
     <%= render :partial => "feedback_reviews/form", :locals => {:review => review} %>
   </div>

diff --git a/app/views/shared/_review_summary.html.erb b/app/views/shared/_review_summary.html.erb
@@ -3,7 +3,7 @@
   <% for review in @product.reviews.approval_filter.preview %>
     <%= render :partial => 'shared/review', :locals => {:review => review} %>
   <% end %>
-  <% if Spree::Reviews::Config[:feedback_rating] && ((Spree::Reviews::Config[:require_login] && current_user) || !Spree::Reviews::Config[:require_login]) %>
+  <% if Spree::Reviews::Config[:feedback_rating] && (!Spree::Reviews::Config[:require_login] || current_user) %>
     <%= link_to t('write_your_own_review'), new_product_review_path(@product), :class => "button" %>
   <% end %>
 </div>

diff --git a/app/views/shared/_reviews.html.erb b/app/views/shared/_reviews.html.erb
@@ -3,7 +3,7 @@
   <% for review in @product.reviews.approval_filter %>
     <%= render :partial => 'shared/review', :locals => {:review => review} %>
   <% end %>
-  <% if (Spree::Reviews::Config[:require_login] && current_user) || !Spree::Reviews::Config[:require_login] %>
-  <%= link_to t('write_your_own_review'), new_product_review_path(@product), :class => "button" %>
+  <% if !Spree::Reviews::Config[:require_login] || current_user %>
+    <%= link_to t('write_your_own_review'), new_product_review_path(@product), :class => "button" %>
   <% end %>
 </div>