First draft for a $.Widget _super method

jstroem · Jun 17, 2010 · 30d468d · 30d468d
1 parent aa416fc
commit 30d468d
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 5 deletions.
diff --git a/tests/unit/widget/widget.js b/tests/unit/widget/widget.js
@@ -165,4 +165,21 @@ test(".widget() - overriden", function() {
 	same(wrapper[0], $("<div></div>").testWidget().testWidget("widget")[0]);
 });
 
+test("_super", function() {
+	expect(2);
+	$.widget("sup.parent", {
+		log: function() {
+			ok( this.called );
+		}
+	});
+	$.widget("sup.child", $.sup.parent, {
+		log: function() {
+			this.called = true;
+			ok( true );
+			this._super("log");
+		}
+	});
+	$("<div></div>").child().child("log");
+});
+
 })(jQuery);
diff --git a/ui/jquery.ui.autocomplete.js b/ui/jquery.ui.autocomplete.js
@@ -163,7 +163,7 @@ $.widget( "ui.autocomplete", {
 			.removeAttr( "aria-autocomplete" )
 			.removeAttr( "aria-haspopup" );
 		this.menu.element.remove();
-		$.Widget.prototype.destroy.call( this );
+		this._super( "destroy" );
 	},
 
 	_setOption: function( key ) {

diff --git a/ui/jquery.ui.button.js b/ui/jquery.ui.button.js
@@ -226,7 +226,7 @@ $.widget( "ui.button", {
 			this.buttonElement.removeAttr( "title" );
 		}
 
-		$.Widget.prototype.destroy.call( this );
+		this._super( "destroy" );
 	},
 
 	_setOption: function( key, value ) {
@@ -358,7 +358,7 @@ $.widget( "ui.buttonset", {
 			.end()
 			.button( "destroy" );
 
-		$.Widget.prototype.destroy.call( this );
+		this._super( "destroy" );
 	}
 });
 

diff --git a/ui/jquery.ui.widget.js b/ui/jquery.ui.widget.js
@@ -62,7 +62,8 @@ $.widget = function( name, base, prototype ) {
 		namespace: namespace,
 		widgetName: name,
 		widgetEventPrefix: $[ namespace ][ name ].prototype.widgetEventPrefix || name,
-		widgetBaseClass: fullName
+		widgetBaseClass: fullName,
+		base: base.prototype
 	}, prototype );
 
 	$.widget.bridge( name, $[ namespace ][ name ] );
@@ -145,7 +146,11 @@ $.Widget.prototype = {
 	},
 	_create: function() {},
 	_init: function() {},
-
+
+	_super: function( method ) {
+		this.base[ method ].apply( this, $.makeArray( arguments ).slice( 1 ) );
+	},
+
 	destroy: function() {
 		this.element
 			.unbind( "." + this.widgetName )