Wip/features and fixes for 2.0 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible (except input).
* Remove all continuations code. * Update documentation. * Add new `fileLines` method to Using. * Bump version to 2.0 * Shed a tear over the loss of continuations in Scala.
jsuereth
force-pushed
the
wip/features-and-fixes-for-2.0
branch
from
c88e4ce
to
334742a
Compare
| def open: T = { | ||
| val parent = source.getParentFile | ||
| if(parent != null) { | ||
| // TODO - use an IO library for this |
There was a problem hiding this comment.
You might want to retry 100 times like sbt.IO.
There was a problem hiding this comment.
was this a serious comment?
jsuereth
added a commit
that referenced
this pull request
Mar 14, 2015
Wip/features and fixes for 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
sbt.Usingin theorg.scala-sbt % sbtlibraryReview by @eed3si9n for the sbt.Using port.
Note: This does remove some API which isn't deprecated in 1.x. We can backport those deprecations after we solidify on what 2.0 looks like/means.