Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support Nx workspace.json version 2 #116

Closed
1 task done
evanfuture opened this issue Nov 10, 2021 · 8 comments
Closed
1 task done

Feature: Support Nx workspace.json version 2 #116

evanfuture opened this issue Nov 10, 2021 · 8 comments
Assignees

Comments

@evanfuture
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is this a regression?

No

Current behavior

When extracting, the lib tries to find the projectBasePath based on either angular.json or workspace.json configurations. But when using the project.json format with workspace.json version 2, the workspace.json only contains a reference to the path to the project.json, and that file then contains the sourceRoot and projectType.

Essentially, when migrating to this new format, eg with nx generate @nrwl/workspace:convert-to-nx-project --all, the extract command fails.

Expected behavior

Nx workspace version 2 with project specific configs is supported.

Please provide a link to a minimal reproduction of the bug

Not sure how with this...

Transloco Config

No response

Debug Logs

No response

Please provide the environment you discovered this bug in

Transloco: 
Transloco Keys Manager:
Angular:
Node: 
Package Manager: 
OS:

Additional context

No response

I would like to make a pull request for this bug

Yes 🚀

evanfuture added a commit to evanfuture/transloco-keys-manager that referenced this issue Nov 10, 2021
@shaharkazaz shaharkazaz changed the title Bug: Extract command fails when using Nx workspace.json version 2 Feature: Support Nx workspace.json version 2 Nov 19, 2021
evanfuture added a commit to evanfuture/transloco-keys-manager that referenced this issue Dec 1, 2021
@EndyKaufman
Copy link
Contributor

i want this feature :(

@shaharkazaz
Copy link
Collaborator

@EndyKaufman Once the comments are fixed I'll merge & release ASAP

@shaharkazaz
Copy link
Collaborator

@EndyKaufman Can you please verify v3.3.0?

@EndyKaufman
Copy link
Contributor

i try

@EndyKaufman
Copy link
Contributor

@shaharkazaz
Copy link
Collaborator

@EndyKaufman Found the issue, please check 3.3.1, add a test for this case as well 👍

@EndyKaufman
Copy link
Contributor

cool!!!!!

extract work in this sample
image

I don't use find but ran for test and got error
image

@shaharkazaz
Copy link
Collaborator

@EndyKaufman The issue is with your transloco config, the Translations path shouldn't be absolute, it's relative to the src.
Change it to assets/i18n and it will work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants