-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support Nx workspace.json version 2 #116
Comments
i want this feature :( |
@EndyKaufman Once the comments are fixed I'll merge & release ASAP |
@EndyKaufman Can you please verify v3.3.0? |
i try |
@shaharkazaz |
@EndyKaufman Found the issue, please check 3.3.1, add a test for this case as well 👍 |
@EndyKaufman The issue is with your transloco config, the Translations path shouldn't be absolute, it's relative to the src. |
Is there an existing issue for this?
Is this a regression?
No
Current behavior
When extracting, the lib tries to find the
projectBasePath
based on either angular.json or workspace.json configurations. But when using the project.json format with workspace.json version 2, the workspace.json only contains a reference to the path to the project.json, and that file then contains the sourceRoot and projectType.Essentially, when migrating to this new format, eg with
nx generate @nrwl/workspace:convert-to-nx-project --all
, the extract command fails.Expected behavior
Nx workspace version 2 with project specific configs is supported.
Please provide a link to a minimal reproduction of the bug
Not sure how with this...
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Additional context
No response
I would like to make a pull request for this bug
Yes 🚀
The text was updated successfully, but these errors were encountered: