Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined default scope translationPath #137

Closed
wants to merge 1 commit into from

Conversation

akyrey
Copy link

@akyrey akyrey commented May 27, 2022

Global scope was using the key translationsPath instead of
translationPath used by scoped array elements
This was causing an undefined when retrieving scope and lang from path

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Cannot read properties of undefined (reading 'split') from translationPath after upgrading to Transloco 4.0.0

Issue Number: #136

What is the new behavior?

Correctly executing the command

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Global scope was using the key translationsPath instead of
translationPath used by scoped array elements
This was causing an undefined when retrieving scope and lang from path
@shaharkazaz shaharkazaz added the good first issue Good for newcomers label Jun 5, 2022
@shaharkazaz
Copy link
Collaborator

@akyrey I think the fix should be a bit more strict, the names here are too confusing.
Would you like to pick this up? 🙂

@akyrey
Copy link
Author

akyrey commented Jul 27, 2022

Sure, I'll try to check it out this weekend!
Any preference for the naming?

@shaharkazaz
Copy link
Collaborator

@akyrey Hi!
Sorry for the delay been busy.
I ended up doing some wider changes and I didn't want to delay the fix anymore.
I appreciate the help and willingness! 😀
Hope to see you contribute again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants