Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commencement speech generator project #100

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Add commencement speech generator project #100

merged 2 commits into from
Aug 1, 2018

Conversation

whatrocks
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 18, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 1f86ead on whatrocks:patch-1 into a0e97df on jsvine:master.

@coveralls
Copy link

coveralls commented Jul 18, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ca5fc8c on whatrocks:patch-1 into a0e97df on jsvine:master.

@jsvine
Copy link
Owner

jsvine commented Jul 21, 2018

Thanks, and neat project! A couple of requests:

  • Could you, on the GitHub page or elsewhere, provide more extensive examples of the script's output? The FloydHub-based generator is neat, but requires people to create an account on FloydHub.

  • Could you remove the promotion of FloydHub from the PR'ed blurb? I don't imagine you meant it as advertising, but I want to be extra-sure that the examples section isn't perceived as an advertising platform.

Thanks again!
Jeremy

@whatrocks
Copy link
Contributor Author

Awesome! Thanks Jeremy. I made the changes you requested. Thanks again for making such an awesome library 👍

@jsvine jsvine merged commit 6968649 into jsvine:master Aug 1, 2018
@jsvine
Copy link
Owner

jsvine commented Aug 1, 2018

Thanks for those changes, and the kind words. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants