Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_words optional argument to make_sentence #128

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

brienna
Copy link
Contributor

@brienna brienna commented May 20, 2020

Lets us specify the minimum number of words we want in the sentence.

Complements the max_words optional argument.

Example:

model.make_sentence(min_words=10)

@coveralls
Copy link

coveralls commented May 20, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling a43ad84 on briennakh:master into 3f3bfd9 on jsvine:master.

@jsvine
Copy link
Owner

jsvine commented May 23, 2020

Hi @briennakh, and many thanks — this looks like a very reasonable addition! Could you add a test that covers this new parameter, so that we retain 100% code coverage? (See Coveralls check above.)

@jsvine
Copy link
Owner

jsvine commented Jun 17, 2020

Thank you, and looks good! Merged and now available in v0.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants