Fix intermittent coverage bug #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See nedbat/coveragepy#198. Although this line is reached, the CPython interpreter does not execute it and so it is incorrectly labeled as missed.
|
Wow, great sleuthing! Thank you for looking into this. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen here, the coverage report oscillates between 100% and 99.67%. The specific line that is sometimes missed can be seen here.
After some digging, I found that this problem is caused by a CPython optimization where the
continuestatement is not explicitly executed when it follows aif True or *:statement. The problem is discussed at nedbat/coveragepy#198.The fix is not ideal but should not cause any future errors. The
test_max_wordsandtest_min_wordstests should make sure that this not covered statement is run when needed.