Fix loading from json when parsed_sentences is None #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big thanks for catching this, Matthew! My gut instinct, in this scenario, would be to handle this in a slightly different way: Rather than passing What do you think? |
|
Yeah, I don't know what I was thinking with kwargs; I'll change that later
today.
…On Mon, Sep 11, 2017, 8:58 AM Jeremy Singer-Vine ***@***.***> wrote:
Big thanks for catching this, Matthew! My gut instinct, in this scenario,
would be to handle this in a slightly different way: Rather than passing
**kwargs, .from_dict(...) can safely assume that if parsed_sentences is
not passed then retain_original is False.
What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#77 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFmlS_M7FpJ6Zo2m5SHJzU3z0f4jOF_8ks5shTx2gaJpZM4PR4vs>
.
|
Otherwise, cannot construct from json when saved with retain_original=False
|
@jsvine OK, it's changed. |
jsvine
added a commit
that referenced
this pull request
Sep 12, 2017
|
Thanks! Merged, and now available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving with
retain_original=False,parsed_sentencesis set toNone. When loading, however, it errors. out. This allows loading withretain_original=False, which will be passed to the constructor and not error out.