Fix identifier handling in require-default-props

jsx-eslint · Aug 11, 2017 · 663838b · 663838b
1 parent f072966
commit 663838b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/rules/require-default-props.js b/lib/rules/require-default-props.js
@@ -109,7 +109,7 @@ module.exports = {
         propWrapperFunctions.has(node.callee.name) &&
         node.arguments && node.arguments[0]
       ) {
-        return node.arguments[0];
+        return resolveNodeValue(node.arguments[0]);
       }
 
       return node;

diff --git a/tests/lib/rules/require-default-props.js b/tests/lib/rules/require-default-props.js
@@ -776,6 +776,26 @@ ruleTester.run('require-default-props', rule, {
         propWrapperFunctions: ['forbidExtraProps']
       }
     },
+    {
+      code: [
+        'function MyStatelessComponent({ foo, bar }) {',
+        '  return <div>{foo}{bar}</div>;',
+        '}',
+        'const propTypes = {',
+        '  foo: PropTypes.string,',
+        '  bar: PropTypes.string.isRequired',
+        '};',
+        'MyStatelessComponent.propTypes = forbidExtraProps(propTypes);'
+      ].join('\n'),
+      errors: [{
+        message: 'propType "foo" is not required, but has no corresponding defaultProp declaration.',
+        line: 5,
+        column: 3
+      }],
+      settings: {
+        propWrapperFunctions: ['forbidExtraProps']
+      }
+    },
     {
       code: [
         'function MyStatelessComponent({ foo, bar }) {',