-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #250 from hamiltondanielb/master
Add prefer-es6-class rule (fixes #247)
- Loading branch information
Showing
5 changed files
with
123 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
ES6 class bodies are more terse than traditional object literals. Methods do not require a `function` keyword and no commas are needed to separate them. This refactoring looks as such: | ||
|
||
Invalid: | ||
|
||
```js | ||
var ExampleComponent = React.createClass({ | ||
render: function() { | ||
return <div onClick={this._handleClick}>Hello, world.</div>; | ||
}, | ||
_handleClick: function() { | ||
console.log(this); | ||
} | ||
}); | ||
``` | ||
|
||
Valid: | ||
|
||
```js | ||
class ExampleComponent extends React.Component { | ||
render() { | ||
return <div onClick={this._handleClick}>Hello, world.</div>; | ||
} | ||
_handleClick() { | ||
console.log(this); | ||
} | ||
} | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/** | ||
* @fileoverview Prefer es6 class instead of createClass for React Component | ||
* @author Dan Hamilton | ||
*/ | ||
'use strict'; | ||
|
||
var componentUtil = require('../util/component'); | ||
|
||
// ------------------------------------------------------------------------------ | ||
// Rule Definition | ||
// ------------------------------------------------------------------------------ | ||
|
||
module.exports = function(context) { | ||
|
||
return { | ||
ObjectExpression: function(node) { | ||
if (componentUtil.isComponentDefinition(context, node)) { | ||
context.report(node, 'Component should use es6 class instead of createClass'); | ||
} | ||
} | ||
}; | ||
}; | ||
|
||
module.exports.schema = []; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/** | ||
* @fileoverview Prefer es6 class instead of createClass for React Component | ||
* @author Dan Hamilton | ||
*/ | ||
'use strict'; | ||
|
||
// ------------------------------------------------------------------------------ | ||
// Requirements | ||
// ------------------------------------------------------------------------------ | ||
|
||
var rule = require('../../../lib/rules/prefer-es6-class'); | ||
var RuleTester = require('eslint').RuleTester; | ||
|
||
require('babel-eslint'); | ||
|
||
// ------------------------------------------------------------------------------ | ||
// Tests | ||
// ------------------------------------------------------------------------------ | ||
|
||
var ruleTester = new RuleTester(); | ||
ruleTester.run('prefer-es6-class', rule, { | ||
|
||
valid: [{ | ||
code: [ | ||
'class Hello extends React.Component {', | ||
' render() {', | ||
' return <div>Hello {this.props.name}</div>;', | ||
' }', | ||
'}', | ||
'Hello.displayName = \'Hello\'' | ||
].join('\n'), | ||
ecmaFeatures: { | ||
classes: true, | ||
jsx: true | ||
} | ||
}, { | ||
code: [ | ||
'var Hello = "foo";', | ||
'module.exports = {};' | ||
].join('\n'), | ||
ecmaFeatures: { | ||
jsx: true | ||
} | ||
} | ||
|
||
], | ||
|
||
invalid: [{ | ||
code: [ | ||
'var Hello = React.createClass({', | ||
' displayName: \'Hello\',', | ||
' render: function() {', | ||
' return <div>Hello {this.props.name}</div>;', | ||
' }', | ||
'});' | ||
].join('\n'), | ||
ecmaFeatures: { | ||
classes: true, | ||
jsx: true | ||
}, | ||
errors: [{ | ||
message: 'Component should use es6 class instead of createClass' | ||
}] | ||
} | ||
]}); |