Fix jsx-uses-vars that incorrectly marked some variables as used (fixes

#694)
jsx-eslint · Jul 25, 2016 · dcc0294 · dcc0294
1 parent 046a723
commit dcc0294
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/lib/rules/jsx-uses-vars.js b/lib/rules/jsx-uses-vars.js
@@ -20,11 +20,22 @@ module.exports = function(context) {
       variableUtil.markVariableAsUsed(context, node.expression.name);
     },
 
-    JSXIdentifier: function(node) {
-      if (node.parent.type === 'JSXAttribute') {
+    JSXOpeningElement: function(node) {
+      var name;
+      if (node.name.namespace && node.name.namespace.name) {
+        // <Foo:Bar>
+        name = node.name.namespace.name;
+      } else if (node.name.name) {
+        // <Foo>
+        name = node.name.name;
+      } else if (node.name.object && node.name.object.name) {
+        // <Foo.Bar> - node.name.object.name
+        name = node.name.object.name;
+      } else {
         return;
       }
-      variableUtil.markVariableAsUsed(context, node.name);
+
+      variableUtil.markVariableAsUsed(context, name);
     }
 
   };

diff --git a/tests/lib/rules/jsx-uses-vars.js b/tests/lib/rules/jsx-uses-vars.js
@@ -112,6 +112,22 @@ ruleTester.run('no-unused-vars', rule, {
         React.render(<App unused=""/>);',
       errors: [{message: '\'unused\' is defined but never used'}],
       parserOptions: parserOptions
+    }, {
+      code: '\
+        /*eslint jsx-uses-vars:1*/\
+        var App;\
+        var Hello;\
+        React.render(<App:Hello/>);',
+      errors: [{message: '\'Hello\' is defined but never used'}],
+      parserOptions: parserOptions
+    }, {
+      code: '\
+        /*eslint jsx-uses-vars:1*/\
+        var Button;\
+        var Input;\
+        React.render(<Button.Input unused=""/>);',
+      errors: [{message: '\'Input\' is defined but never used'}],
+      parserOptions: parserOptions
     }, {
       code: '\
         /*eslint jsx-uses-vars:1*/\