Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsx-no-leaked-render): avoid unnecessary negation operators and ternary branches deletion #3299

merged 1 commit into from May 27, 2022


Copy link

@Belco90 Belco90 commented May 26, 2022

Closes #3297
Relates to #3292

This fixes:

  • adding unnecessary negation operators
  • delete valid ternary branches

tests/lib/rules/jsx-no-leaked-render.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #3299 (f74e30c) into master (c42b624) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Current head f74e30c differs from pull request most recent head e7fc22f. Consider uploading reports for the commit e7fc22f to get more accurate results

@@           Coverage Diff           @@
##           master    #3299   +/-   ##
  Coverage   97.68%   97.69%           
  Files         123      123           
  Lines        8737     8746    +9     
  Branches     3166     3168    +2     
+ Hits         8535     8544    +9     
  Misses        202      202           
Impacted Files Coverage Δ
lib/rules/jsx-no-leaked-render.js 98.24% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42b624...e7fc22f. Read the comment docs.

ljharb approved these changes May 26, 2022
Copy link

@ljharb ljharb left a comment

assuming tests pass

@ljharb ljharb force-pushed the jsx-no-leaked-render_fixes branch from f74e30c to e7fc22f Compare May 26, 2022
@ljharb ljharb merged commit e7fc22f into jsx-eslint:master May 27, 2022
243 checks passed
Copy link

pke commented Jun 8, 2022

Any plans when this will be released?

Copy link

ljharb commented Jun 9, 2022

Nope, we don’t plan release dates, they just happen when we have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

3 participants