Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotation for button-has-type rule #3734

Closed

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Apr 10, 2024

This PR adds JSDoc type annotations to the button-has-type rule.

@y-hsgw
Copy link
Contributor Author

y-hsgw commented Apr 10, 2024

I will close this as it is planned to be addressed in pull request #3731.

@y-hsgw y-hsgw closed this Apr 10, 2024
@y-hsgw y-hsgw deleted the add-type-annotation-button-has-type branch April 10, 2024 06:13
@ljharb
Copy link
Member

ljharb commented Apr 10, 2024

Please note that any meaningful changes to runtime code must be accompanied by tests that fail without the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants