Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses #616 by adding an element,
Sphere3D
, representing a sphere in 3D space. It also adds a usage example,sphere3d.html
.Implementation
The interface is based on
Circle
, but I use ideas fromLine3D
andParametricSurface3D
to link the 3D geometric representation to the 2D display representation (stored inelement2D
).Pitfalls
Sphere3D
isn't consistent with the elements it's based on, because those elements aren't implemented consistently with each other. For example:Circle
uses theCoordsElement.Dist
method thatPoint
inherits. However, there's no 3D analogue ofCoordsElement
: the classPoint3D
descends directly fromGeometryElement
. I therefore added a distance function,Point3D.distance
, directly to thePoint3D
class.isPointType3D
is inconsistent with both the 2D analogueisPointType
, and it also doesn't match the type check done increateLine3D
. Ideally, it would be nice to use the same type check forcreateSphere3D
andcreateLine3D
, but I don't understand the latter well enough to change it.