Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Add maxUnavailable option for rolling updates #291

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

hwoarang
Copy link
Contributor

Allow user to set maxUnavailable option for rolling updates in order
to speed up deployment times on large clusters.

@coveralls
Copy link

coveralls commented Nov 23, 2020

Coverage Status

Coverage remained the same at 19.481% when pulling 56ee37c on hwoarang:add-ds-update-strategy into c24c3c8 on jtblin:master.

@jtblin
Copy link
Owner

jtblin commented Dec 21, 2020

cc @mariusv @walkafwalka can you help reviewing helm charts changes pls?

Copy link
Collaborator

@mariusv mariusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@mariusv mariusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation about the maxUnavailable on the readme on how it will be used.

@walkafwalka
Copy link
Collaborator

I prefer using something more flexible for updateStrategy but that would require a breaking change. We should take note of situations like this.

  updateStrategy: {}
  #  rollingUpdate:
  #    maxUnavailable: 1
  #  type: RollingUpdate

Besides the documentation, LGTM.

@rdelpret
Copy link

rdelpret commented Jan 5, 2021

@walkafwalka I 100% agree, I reached out to @mariusv on slack about it to propose the same before I saw this PR but didn't get an answer.

@rdelpret
Copy link

rdelpret commented Jan 5, 2021

Regardless of implementation, this one is urgent for us as large clusters need some pretty high timeouts set w/ helm to get through a rolling update with the hard-coded settings.

Allow user to set maxUnavailable option for rolling updates in order
to speed up deployment times on large clusters.
@hwoarang
Copy link
Contributor Author

I have updated the default value and added the missing doc. I opted not to implement the braking change at this point. However, if you think we should do it then I can do that no problem

@hwoarang hwoarang requested a review from mariusv January 13, 2021 11:21
@walkafwalka walkafwalka merged commit 4e6e50f into jtblin:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants