Add readiness probe to helm chart #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add readiness probe support to the helm chart
|
@jtblin could you please have a look at this PR? |
| successThreshold: {{ .Values.livenessProbe.successThreshold }} | ||
| failureThreshold: {{ .Values.livenessProbe.failureThreshold }} | ||
| timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }} | ||
| readinessProbe: |
There was a problem hiding this comment.
do you need a {{- if .Values.readinessProbe.enabled }} for this block?
There was a problem hiding this comment.
good catch!
Addressed
walkafwalka
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a readiness probe. This is important in case it's needed kube2iam to be in ready status before scheduling any other workload that relies on kube2iam.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes:
Checklist chart
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]