Adding features to Moo command line util. #1

Merged
merged 3 commits into from Jan 25, 2012

Conversation

2 participants
@ExternalReality
Contributor

ExternalReality commented Jan 21, 2012

This commit refactors and cleans up Moo a bit. I find the code easier to extend in this form. I took some liberties with the representation of command options as they are now parsed with System.Console.GetOps and they are represented as just plain strings. Last, the order of required arguments and optional arguments to the Moo command has been transposed due to the way GetOpt works. Let me know if this patch is acceptable. If not, let me know what changes need to be made to make it acceptable.

By the way, I am partial to the code style used by the Snap Web Framework. I hope this is not a problem.

Regards,
Eric

@jtdaugherty

This comment has been minimized.

Show comment Hide comment
@jtdaugherty

jtdaugherty Jan 21, 2012

Owner

Thanks! This is great. I only have one small request, which is that the blocks of docstrings (e.g., those containing "------") be changed to Haddock syntax and the long lines of dashes be removed. Other than that, thanks a ton! If that sounds reasonable to you, do that and I'll accept.

For future reference, large commits are a bit harder for me to evaluate. This one isn't, chiefly because it mostly moves code around, but smaller, more incremental changes will be much easier to measure.

Thanks for putting time into this!

Owner

jtdaugherty commented Jan 21, 2012

Thanks! This is great. I only have one small request, which is that the blocks of docstrings (e.g., those containing "------") be changed to Haddock syntax and the long lines of dashes be removed. Other than that, thanks a ton! If that sounds reasonable to you, do that and I'll accept.

For future reference, large commits are a bit harder for me to evaluate. This one isn't, chiefly because it mostly moves code around, but smaller, more incremental changes will be much easier to measure.

Thanks for putting time into this!

@ExternalReality

This comment has been minimized.

Show comment Hide comment
@ExternalReality

ExternalReality Jan 21, 2012

Contributor

Sounds reasonable.

Contributor

ExternalReality commented Jan 21, 2012

Sounds reasonable.

External Reality
Correct command options that were inadvertantly messed up. Probably n…
…eed to add some kind of expect-lite style test around this.

jtdaugherty pushed a commit that referenced this pull request Jan 25, 2012

Jonathan Daugherty
Merge pull request #1 from ExternalReality/master
Moo command source refactoring for extensibility

@jtdaugherty jtdaugherty merged commit 6f47bec into jtdaugherty:master Jan 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment