stats: worker count and list #81

gavinbarnard · 2021-04-04T08:52:36Z

Add support for the xmrig --rig-id option, add worker_count as a statistic in /stats, and a list of up to as many connected rigs that will fit in a 1mb buffer

I know this is probably terrible, please be gentle, my c skills are rusty.

jtgrassie

My main concern with this is that it only caters to small scale miners (<32 workers), but there are also some inefficiencies with how this is implemented and a load of indentation issues.

src/pool.c

src/webui.c

src/pool.h

src/pool.c

jtgrassie · 2021-04-04T17:49:52Z

I know this is probably terrible, please be gentle, my c skills are rusty.

It's not terrible, so thank you for submitting. I tried to capture all my comments in the review above.

The scale point is tricky because some miners have 100s/1000s of workers, thus 32 just isn't enough. As this just returns a list of online worker IDs, it may make more sense to split it off to a different endpoint (e.g. /workers) and then let it be a 1 MB buffer, which can then return ~25k workers.

gavinbarnard · 2021-04-04T23:27:01Z

Thank you for your time to review. I will work to clean up all the bad indentations, and start using a proper IDE. This was all done with vim on my stage system.

I was only supporting listing the first 32 found rig_id from the client. As well yes I am running a fairly small pool, but I guess it is wise to think of the larger scale.

jtgrassie

Per above comments, scale is still an issue. The worker count function can take start/end pointers to 1 MB buffer.

src/pool.c

src/pool.h

src/pool.c

src/pool.h

src/webui.c

src/pool.c

src/webui.c

src/pool.c

src/webui.c

jtgrassie · 2021-04-05T23:10:59Z

Please squash commits and rebase after the last change please. Thanks. Oh, and rename, stats: worker count and list.

jtgrassie · 2021-04-06T03:02:14Z

Super. Thank you. I'll do some tests at the weekend and merge then.

jtgrassie · 2021-04-09T17:37:43Z

Please remove the new commit (5ff5735). If you want to add more functionality after I've merged this PR, you can open a new PR. Thanks.

- buffer size (for systems with smaller thread stack) - terminating NULL in rig-id copy - rename functions/variables - reorder functions - minor formatting issues

jtgrassie reviewed Apr 4, 2021

View reviewed changes