Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Search input alignment #342

Closed
hungerburg opened this issue Feb 24, 2019 · 7 comments
Closed

Search input alignment #342

hungerburg opened this issue Feb 24, 2019 · 7 comments

Comments

@hungerburg
Copy link

Setup

  • Browsers and versions: firefox, chrome
  • MediaWiki version: 1.32
  • Foreground version: latest as of now

Issue

foundation.css adds 1rem margin to the bottom of text inputs; they then do not align with buttons placed besides, e.g. on the special:search form

PS: quite a minor issue for this appealingly slick skin :)

@Hutchy68
Copy link
Collaborator

Hutchy68 commented Mar 8, 2019

I see it around line # 1447 in foundation.css file. Could do a general cleanup of foreground.css at the same time to reset the margin: 0 0 1rem 0; in foundation.css.

@Hutchy68
Copy link
Collaborator

Just pushed a fix to develop branch. Please test it and let me know. Thanks!

@hungerburg
Copy link
Author

Search form is good now; Still found this http://daimon.myzel.net/Spezial:Exportieren (after quite some looking ;) (in English /Special:Export), 1rem bottom margin

@Hutchy68
Copy link
Collaborator

Thanks for the heads up. I found a couple other things in need of tweaking too.

@Hutchy68 Hutchy68 removed the solved label Mar 12, 2019
Hutchy68 added a commit to Hutchy68/foreground that referenced this issue Mar 13, 2019
@hungerburg
Copy link
Author

Hmm, all of a sudden, the search input was up 1rem again; curious?
Line 1161 assets/stylesheets/foreground.css has a spare } right curly brace

@Hutchy68
Copy link
Collaborator

Oops, just fixed in develop branch

@hungerburg
Copy link
Author

Everything looks fine now, closing

Hutchy68 added a commit that referenced this issue Jan 16, 2020
* Merging in changes to address issues and compatability, see CHANGELOG.md

* Set version to 2.2.1dev for develop branch

* More changes to CSS for issue #342

* Fix license visibility on GitHub

* Duh, need License in top line too

* Fixing extra bracket in CSS and moving some code to select attribute

* Fix for issue #345 and other improvements, notes in CHANGELOG.md

* Fixed issue with annoying "->" in top bar. (#350)

In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing "</li>" tag and unbalanced PHP curly brackets. This change fixes the problem.

* Bump version for bug fix

* Prep for Version Release (#351)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Bump version for bug fix

*  Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)

*  Replace usge of long deprecated and removed wfSuppressWarnings

* Update Foreground.skin.php

* Update Foreground.skin.php

Thanks @paladox

* Prep for Version Bump, merge to master for release

Co-authored-by: Kai Özer <robo-fish@users.noreply.github.com>
Co-authored-by: paladox <paladox@users.noreply.github.com>
Hutchy68 added a commit that referenced this issue Jan 18, 2020
* Merging in changes to address issues and compatability, see CHANGELOG.md

* Set version to 2.2.1dev for develop branch

* More changes to CSS for issue #342

* Fix license visibility on GitHub

* Duh, need License in top line too

* Fixing extra bracket in CSS and moving some code to select attribute

* Fix for issue #345 and other improvements, notes in CHANGELOG.md

* Fixed issue with annoying "->" in top bar. (#350)

In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing "</li>" tag and unbalanced PHP curly brackets. This change fixes the problem.

* Bump version for bug fix

* Prep for Version Release (#351)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Bump version for bug fix

*  Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)

*  Replace usge of long deprecated and removed wfSuppressWarnings

* Update Foreground.skin.php

* Update Foreground.skin.php

Thanks @paladox

* Prep for Version Bump, merge to master for release

* Reset version to 2.2.3dev

* Dev updates with Localization (#355)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Bump version for bug fix

* Prep for Version Bump, merge to master for release

* Reset version to 2.2.3dev

Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>

* Revert " Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)"

This reverts commit fff0786.

* Prep for release 2.2.4

Co-authored-by: Kai Özer <robo-fish@users.noreply.github.com>
Co-authored-by: paladox <paladox@users.noreply.github.com>
Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants