Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings #352

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings #352

merged 3 commits into from
Jan 16, 2020

Conversation

paladox
Copy link
Contributor

@paladox paladox commented Dec 22, 2019

No description provided.

@paladox paladox changed the title Replace usge of long deprecated and removed wfSuppressWarnings Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings Dec 23, 2019
Steinsplitter
Steinsplitter approved these changes Jan 2, 2020
View reviewed changes
Copy link

@Steinsplitter Steinsplitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

@Hutchy68 Hutchy68 merged commit fff0786 into jthingelstad:develop Jan 16, 2020
Hutchy68 added a commit that referenced this pull request Jan 16, 2020
@Hutchy68 @robo-fish @paladox
Merging All Changes Into Master for Release (#354)
4390801 
* Merging in changes to address issues and compatability, see CHANGELOG.md

* Set version to 2.2.1dev for develop branch

* More changes to CSS for issue #342

* Fix license visibility on GitHub

* Duh, need License in top line too

* Fixing extra bracket in CSS and moving some code to select attribute

* Fix for issue #345 and other improvements, notes in CHANGELOG.md

* Fixed issue with annoying "->" in top bar. (#350)

In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing "</li>" tag and unbalanced PHP curly brackets. This change fixes the problem.

* Bump version for bug fix

* Prep for Version Release (#351)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Bump version for bug fix

*  Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)

*  Replace usge of long deprecated and removed wfSuppressWarnings

* Update Foreground.skin.php

* Update Foreground.skin.php

Thanks @paladox

* Prep for Version Bump, merge to master for release

Co-authored-by: Kai Özer <robo-fish@users.noreply.github.com>
Co-authored-by: paladox <paladox@users.noreply.github.com>
@paladox paladox deleted the patch-31 branch January 16, 2020 18:26
@kghbln
Copy link
Contributor

kghbln commented Jan 17, 2020 •
edited
Loading

@paladox @Hutchy68 So this definitively broke compat with MediaWiki 1.31.x LTS and earlier. It will be great to know if MW 1.32.x and MW 1.34.x for me being able to update the docu.

This is yet another utterly ridiculous situation where it is not possible to support MediaWiki from one LTS to the next one without extra effort.

Setup

  • MediaWiki | 1.31.6 (c168a3f)13:28, 19 December 2019
  • PHP | 7.0.33-0+deb9u6 (apache2handler)
  • MariaDB | 10.1.41-MariaDB-0+deb9u1
  • Foreground 2.2.3

Issue

Fatal error: Uncaught Error: Class 'Wikimedia\AtEase\AtEase' not found in /../w/skins/foreground/Foreground.skin.php:63

Stack trace

#0 /../w/includes/skins/SkinTemplate.php(251): foregroundTemplate->execute()
#1 /../w/includes/OutputPage.php(2388): SkinTemplate->outputPage()
#2 /../w/includes/exception/MWExceptionRenderer.php(137): OutputPage->output()
#3 /../w/includes/exception/MWExceptionRenderer.php(54): MWExceptionRenderer::reportHTML(Object(Error))
#4 /../w/includes/exception/MWExceptionHandler.php(75): MWExceptionRenderer::output(Object(Error), 2)
#5 /../w/includes/exception/MWExceptionHandler.php(149): MWExceptionHandler::report(Object(Error))
#6 /../w/includes/exception/MWExceptionHandler.php(121): MWExceptionHandler::handleException(Object(Error))
#7 [internal function]: MWExceptionHandler::handleUncaughtException(Object(Error))
#8 {main} throw in /../w/skins/foreground/Foreground.skin.php on line 63

Hutchy68 added a commit to Hutchy68/foreground that referenced this pull request Jan 17, 2020
@Hutchy68
Revert " Replace usge of long deprecated and removed wfSuppressWarnin…
2dab535 
…gs and wfRestoreWarnings (jthingelstad#352)"

This reverts commit fff0786.
Hutchy68 added a commit that referenced this pull request Jan 18, 2020
@Hutchy68
Release 2.2.4 (#356)
b0fa210 
* Revert " Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)"

This reverts commit fff0786.

* Prep for release 2.2.4
Hutchy68 added a commit that referenced this pull request Jan 18, 2020
@Hutchy68 @robo-fish
@paladox @translatewiki
Release 2.2.4 (#357)
2695828 
* Merging in changes to address issues and compatability, see CHANGELOG.md

* Set version to 2.2.1dev for develop branch

* More changes to CSS for issue #342

* Fix license visibility on GitHub

* Duh, need License in top line too

* Fixing extra bracket in CSS and moving some code to select attribute

* Fix for issue #345 and other improvements, notes in CHANGELOG.md

* Fixed issue with annoying "->" in top bar. (#350)

In my use of Foreground, I don't need the left dropdown menu in the top bar. Disabling it revealed a bug in which an annoying "->" appears in the top bar. It is caused by a missing "</li>" tag and unbalanced PHP curly brackets. This change fixes the problem.

* Bump version for bug fix

* Prep for Version Release (#351)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Bump version for bug fix

*  Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)

*  Replace usge of long deprecated and removed wfSuppressWarnings

* Update Foreground.skin.php

* Update Foreground.skin.php

Thanks @paladox

* Prep for Version Bump, merge to master for release

* Reset version to 2.2.3dev

* Dev updates with Localization (#355)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Bump version for bug fix

* Prep for Version Bump, merge to master for release

* Reset version to 2.2.3dev

Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>

* Revert " Replace usge of long deprecated and removed wfSuppressWarnings and wfRestoreWarnings (#352)"

This reverts commit fff0786.

* Prep for release 2.2.4

Co-authored-by: Kai Özer <robo-fish@users.noreply.github.com>
Co-authored-by: paladox <paladox@users.noreply.github.com>
Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Steinsplitter Steinsplitter Steinsplitter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paladox @kghbln @Steinsplitter @Hutchy68