Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop td media consolidate #13

Merged
merged 4 commits into from
Sep 3, 2020
Merged

Conversation

tydillon
Copy link
Collaborator

@tydillon tydillon commented Sep 3, 2020

Consolidates both media models

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #13 into develop will increase coverage by 16.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop      #13       +/-   ##
==============================================
+ Coverage      39.37%   55.44%   +16.06%     
+ Complexity       532      530        -2     
==============================================
  Files            124       80       -44     
  Lines           2900     2056      -844     
  Branches           1        1               
==============================================
- Hits            1142     1140        -2     
+ Misses          1758      916      -842     
Impacted Files Coverage Δ Complexity Δ
...redox/datamodel/clinicalsummary/common/Author.java 64.86% <ø> (ø) 11.00 <0.00> (ø)
...edox/datamodel/clinicalsummary/common/Company.java 60.00% <ø> (ø) 6.00 <0.00> (ø)
...ox/datamodel/clinicalsummary/common/Custodian.java 58.82% <ø> (ø) 5.00 <0.00> (ø)
...redox/datamodel/clinicalsummary/common/Header.java 60.00% <ø> (ø) 6.00 <0.00> (ø)
...edox/datamodel/clinicalsummary/common/Insured.java 63.63% <ø> (ø) 10.00 <0.00> (ø)
...va/redox/datamodel/clinicalsummary/common/PCP.java 64.86% <ø> (ø) 11.00 <0.00> (ø)
...dox/datamodel/clinicalsummary/common/Producer.java 58.82% <ø> (ø) 5.00 <0.00> (ø)
...dox/datamodel/clinicalsummary/common/Relation.java 60.86% <ø> (ø) 7.00 <0.00> (ø)
...tamodel/clinicalsummary/patientpush/Encounter.java 67.92% <ø> (ø) 15.00 <0.00> (ø)
...model/clinicalsummary/patientpush/PatientPush.java 71.69% <ø> (ø) 33.00 <0.00> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34da702...3a7cee2. Read the comment docs.

Copy link
Owner

@jtravan3 jtravan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if my comments make sense. We can go ahead and merge this if we want but we should probably do another consolidation of all the common packages into a single redox.datamodel.common package.

package redox.datamodel.media.replace;
package redox.datamodel.media.common;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a redox.datamodel.common instead? Because we already have an Address object right? Rather than doing common objects per Redox module we should probably do an overall common

Copy link
Owner

@jtravan3 jtravan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jtravan3 jtravan3 merged commit dd534b4 into develop Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants