-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop td media consolidate #13
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #13 +/- ##
==============================================
+ Coverage 39.37% 55.44% +16.06%
+ Complexity 532 530 -2
==============================================
Files 124 80 -44
Lines 2900 2056 -844
Branches 1 1
==============================================
- Hits 1142 1140 -2
+ Misses 1758 916 -842
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if my comments make sense. We can go ahead and merge this if we want but we should probably do another consolidation of all the common packages into a single redox.datamodel.common
package.
package redox.datamodel.media.replace; | ||
package redox.datamodel.media.common; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a redox.datamodel.common
instead? Because we already have an Address
object right? Rather than doing common objects per Redox module we should probably do an overall common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Consolidates both media models