Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds medication, notes, and vaccination #34

Merged
merged 5 commits into from
Feb 2, 2021
Merged

Adds medication, notes, and vaccination #34

merged 5 commits into from
Feb 2, 2021

Conversation

tydillon
Copy link
Collaborator

IS 78, 79, 81, and 92. Adds medication, notes, and vaccination models.

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #34 (4a90eba) into master (ba608bf) will decrease coverage by 1.49%.
The diff coverage is 84.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
- Coverage     89.06%   87.57%   -1.50%     
- Complexity     1420     2047     +627     
============================================
  Files            98      141      +43     
  Lines          2534     3718    +1184     
  Branches          1        1              
============================================
+ Hits           2257     3256     +999     
- Misses          277      462     +185     
Impacted Files Coverage Δ Complexity Δ
...model/clinicalsummary/common/AdvanceDirective.java 95.12% <ø> (ø) 24.00 <0.00> (ø)
...redox/datamodel/clinicalsummary/common/Author.java 89.18% <ø> (ø) 20.00 <0.00> (ø)
...datamodel/clinicalsummary/common/Immunization.java 88.23% <ø> (ø) 10.00 <0.00> (ø)
...edox/datamodel/clinicalsummary/common/Insured.java 87.87% <ø> (ø) 18.00 <0.00> (ø)
...model/clinicalsummary/common/MedicalEquipment.java 88.23% <ø> (ø) 10.00 <0.00> (ø)
...inicalsummary/common/MedicationAdministration.java 93.10% <ø> (ø) 18.00 <0.00> (ø)
...va/redox/datamodel/clinicalsummary/common/PCP.java 89.18% <ø> (ø) 20.00 <0.00> (ø)
...edox/datamodel/clinicalsummary/common/Problem.java 96.07% <ø> (ø) 32.00 <0.00> (ø)
...tamodel/clinicalsummary/patientpush/Encounter.java 96.22% <ø> (ø) 30.00 <0.00> (ø)
...model/clinicalsummary/patientpush/PatientPush.java 100.00% <ø> (ø) 63.00 <0.00> (ø)
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba608bf...4a90eba. Read the comment docs.

Copy link
Owner

@jtravan3 jtravan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look and see if we can change first and last name fields to strings.

At some point, we want to remove any kind of Object references. Object is a catch-all and very abstract. We either want those fields to be Strings or a complex object that we can reuse.

@jtravan3 jtravan3 merged commit 39f5413 into master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants