speed up node cleanup for big clusters #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviving this from the graveyard, as I now am also running into this problem. @robbyt, have you made any further progress on this, noted any bugs, breaking changes with current codebase, etc? It would be great if a similar approach could be used for adding the nodes as well... I may implement this later this week. Thanks! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with cluster sizes > 200 nodes, the known_hosts and /etc/hosts cleanup is extremely slow. I'm currently working with a cluster of 400 nodes, and removing a single node takes almost 45mns when starcluster is run from a m1.large instance.
With this change, the remove node takes 4mns on my 400 node cluster, with the same end results.