-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rpt-any #392
feat: add rpt-any #392
Conversation
just tried it but it doesn't work. when i press rpt-any, it just pauses and doesn't output any input you make for a couple seconds. |
Interesting, I added a unit test (without changing the code logic) and did some manual testing today and it's working as intended for me. I'm not able to reproduce the pause. |
I've tried this patch. Tried to repeat a Control+V (paste) action, but instead of repeating it it only repeated the "V" key. I've used only keys on the main layer to test it (to be on the simpler side of things). Interestingly enough, it added an unexpected feature I find useful, being able to repeat a key, not only one time like rpt does, but with holding it keeps repeating the key (but only works if the rpt-any action is on the base layer).
|
There's already a stable feature for that, that was added not-too-long time ago: |
weird, i could try recording me pressing rpt-any and showing you what happens |
In testing some more, I fixed a potential usability issue with
While writing this though, I wonder if there are other actions where it would make sense to repeat the top-level instead of the final. Maybe |
Testing again after this multi fix, I'm not seeing any issues still. Space is
Debug output
The output is as expected - note that t02 looks a little funny, but is expected because the S of S-a isn't released until after everything else is pressed too:
Some |
I don't know if this is intended, but when using this action |
yep i had a problem with putting rpt-any on a tap-hold key so this might be related |
That sounds like it might be the issue. The current If there is no good use case for allowing these layer actions to be repeated though (and I can't think of any right now), I could special-case these out to not be repeatable. |
Implements #389
I haven't tested this. Seems like I could add a unit test to keyberon for this. Will publish for now in case someone wants to do manual testing for me though 😁