Polish approx #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add examples of binary arithmetic operators * Add note about element type implementing operator
Instead of using square initial matrices, use 2x3 matrices to make it clearer in the example which Axis is calculated over Signed-off-by: JP-Ellis <josh@jpellis.me>
Improve documentation for sum_axis and mean_axis
This looks a little nicer.
* Improve docs of .raw_dim(), .shape(), and .strides() * Add example of .shape()/.raw_dim()
Fixes rust-ndarray#609 (assuming we don't want to actually add conversion methods).
- fixed typo in ArrayDisplayMode comment - updated ArrayDisplayMode constructor to use shape instead of array - fixed output for complex dimensions
Test if every element of the iterator matches a predicate. This is useful, for instance, to test if two matrices are elementwise "similar" (within a given threshold) without modifying the matrices.
A different approach
Implement Zip::all()
…matting Implemented a function for smarter debug formatting.
* Add `logspace` constructor for Array1 Signed-off-by: JP-Ellis <josh@jpellis.me> * Add logspace tests Signed-off-by: JP-Ellis <josh@jpellis.me> * More extensive logspace tests Signed-off-by: JP-Ellis <josh@jpellis.me> * Remove print statements in doc tests Signed-off-by: JP-Ellis <josh@jpellis.me> * Add `geomspace` and make `logspace` compatible with NumPy Signed-off-by: JP-Ellis <josh@jpellis.me>
|
@LukeMathWalker Thanks for working on this! That's a big help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the deprecation mark for
all_close, generalized the implementation ofapprox's trait (using your PR onapprox) and replaced all usages ofall_closein tests and doc tests.And I have merged master into the branch... which causes this nasty diff 😅