Fix Forte [Ambit Part] #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2022
|
This looks good to me. A comment on the style. Before this PR, load/save were implemented as free functions. I agree that save can be moved to a class function, but this now puts load/save in two different parts (free/member). Then perhaps it would a good idea to make save a static class function. I am curious how other codes handle this aspect. @jturney: any thoughts on this? |
fevangelista
approved these changes
Mar 26, 2022
|
That's fine with me, but I can also finish moving save/load to class functions if you want. Jet's policy has been that if tests are passing and he's approved, it's good to merge. |
|
Class functions++!
-Rob
…On Sat, Mar 26, 2022 at 1:00 PM Jonathon Misiewicz ***@***.***> wrote:
That's fine with me, but I can also finish moving save/load to class
functions if you want.
Jet's policy has been that if tests are passing and he's approved, it's
good to merge.
—
Reply to this email directly, view it on GitHub
<#53 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAULGP6I73TYTCUEYJOYBQTVB5UFBANCNFSM5RVXIQRA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Then let's do class functions (good to see you here @robparrish!). |
|
Done. The static function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes so that
Psican do DIIS on anambit.BlockedTensor, as required by theforteplugin.This PR accomplishes the following, as needed by this Psi PR:
load_blocked_tensormethod to Python asBlockedTensor.loadsavefunction for BlockedTensor to a method, and exposes it py-sideBlockedTensorBlockedTensorBlockedTensor@fevangelista @lcyyork