Implement block() function

[realcnbs]

This one IMO is very important to have, allows a lot of flexibility for re-usability and composition of templates. Used a lot in symfony forms twig extension here which I am considering to port (at least partially) to jtwig as independent module.

http://twig.sensiolabs.org/doc/functions/block.html

I didn't look into code yet for particularly this one, but it feels like it should be some kind of functionality which would insert duplicates into the render objects tree.

[joao-de-melo]

In terms of architecture, this feature will require functions to have access to the rendering context.

This possible by changing the function api.

I had a tech task in mind which could be picked up here.

Basically I would like to make functions more developer friendly. That is possible if we use reflection strategies like spring to run functions. By doing so we simplify all function implementations (removing the initial requires validation) by havinf Java defined arguments.

Then, for this story we just need to have a function which will receive this special argument, the rendering context.

[realcnbs]

Yeah, functions API should be refactored for sure, because similar kind of functionality we will need in the parent() function.
Not sure what exact strategies you mean but it would be really great to have functions to be type safe. That makes me think that we will need multiple function methods for every variation like: range(1,10) and range(1,10,2)
Also functions will have to know their position in the rendered object tree as well as source file information (line, position, etc).
Could you point me to the strategies you mentioned?

[joao-de-melo]

I'm doing some work on it. But I'm talking about this: http://docs.spring.io/spring/docs/3.2.x/spring-framework-reference/html/mvc.html#mvc-ann-typeconversion

[thomas-p-wilson]

I was moving toward implementation on this one, but realized that as the jtwig-functions module is separate from the jtwig-core module, @JtwigFunctions cannot have access to the RenderContext in a typesafe manner. To add jtwig-core as a dependency of jtwig-functions would introduce a circular reference in the Reactor build. I see two options then: 1) produce a contract module which retains those elements common to both, or 2) fold jtwig-functions into jtwig-core. Thoughts?

[joao-de-melo]

Try creating the function in the jtwig-core itself. That's what I was thinking about.

[thomas-p-wilson]

Okay, I should be able to do that!
On Oct 19, 2014 7:11 AM, "João Melo" notifications@github.com wrote:

Try creating the function in the jtwig-core itself. That's what I was
thinking about.

—
Reply to this email directly or view it on GitHub
https://github.com/lyncode/jtwig/issues/88#issuecomment-59646472.

[thomas-p-wilson]

The block() function was implemented in PR #263. Closing.