Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block function persuant to #88 #229

Merged
merged 1 commit into from
Nov 20, 2014
Merged

Add block function persuant to #88 #229

merged 1 commit into from
Nov 20, 2014

Conversation

thomas-p-wilson
Copy link

Some things to note:

  1. Accepts any expression as the block name parameter, just like Twig.
  2. The block function can be nested, just like in Twig, and as exemplified in the associated acceptance tests.
  3. Unlike Twig, the 'block' keyword cannot be used as the name of a block or variable. I attempted to fix that here, but it was going to be too large a change and far too unrelated. Will pull that out into a different issue.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) when pulling 23c9cc1 on thomas-p-wilson:feature-block-function into 32762a2 on lyncode:master.

joao-de-melo pushed a commit that referenced this pull request Nov 20, 2014
@joao-de-melo joao-de-melo merged commit 6b95969 into jtwig:master Nov 20, 2014
@joao-de-melo joao-de-melo added this to the 3.1.0 milestone Nov 20, 2014
@thomas-p-wilson thomas-p-wilson deleted the feature-block-function branch November 29, 2014 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants