Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 3D Fishing Hooks #210

Merged
merged 4 commits into from Jan 29, 2023

Conversation

lonefelidae16
Copy link
Contributor

resolve #119

3D-ize the Fishing Bobber.

A new configurable option is available, I haven’t added it to the settings screen yet. Please check BedrockifyClientSettings.java.

  • boolean BedrockifyClientSettings#fishingBobber3D
    • uses in FishingBobberEntityRendererMixin

Changes

  • new mixin has registered

    • mixin.client.features.fishingBobber.FishingBobberEntityRendererMixin
  • new configurable option is available

    • boolean BedrockifyClientSettings#fishingBobber3D
  • new files

    • client/features/fishingBobber/FishingBobber3DModel.java
    • assets/textures/entity/fishing_hook.png
  • update Bedrockify.java

    • introduced new const: String MOD_ID to avoid typos
  • update BedrockifyClient.java

    • register a new entity model: FishingBobber3DModel.MODEL_LAYER

lonefelidae16 and others added 4 commits January 26, 2023 22:01
3D-ize the Fishing Bobber.

* new mixin has registered
  - `mixin.client.features.fishingBobber.FishingBobberEntityRendererMixin`

* new configurable option is available
  - boolean `BedrockifyClientSettings#fishingBobber3D`

* new files
  - `client/features/fishingBobber/FishingBobber3DModel.java`
  - `assets/textures/entity/fishing_hook.png`

* update `Bedrockify.java`
  - introduced new const: String `MOD_ID` to avoid typos

* update `BedrockifyClient.java`
  - register a new entity model: `FishingBobber3DModel.MODEL_LAYER`
@juancarloscp52 juancarloscp52 merged commit 9ce0e7a into juancarloscp52:1.19.3 Jan 29, 2023
@lonefelidae16 lonefelidae16 deleted the feat/3d-bobber branch January 29, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Bedrock's 3D Fishing Hooks
2 participants