-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Bedrock Cauldron #231
Merged
juancarloscp52
merged 7 commits into
juancarloscp52:1.19.4
from
lonefelidae16:feat/cauldron-behavior
Mar 15, 2023
Merged
[feat] Bedrock Cauldron #231
juancarloscp52
merged 7 commits into
juancarloscp52:1.19.4
from
lonefelidae16:feat/cauldron-behavior
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to color the cauldron filled with water and dye the item by it. New configurable option `bedrockCauldron` is available, and I haven't added it to SettingsGUI. Please check `BedrockifySettings.java`. * new configurable option in `BedrockifySettings` - boolean `bedrockCauldron` * new block color tint has registered in `BedrockifyClient` - for `ColoredWaterCauldronBlock` * registered mixins - `mixin.common.features.cauldron.AbstractCauldronBlockMixin` - `mixin.common.features.cauldron.ArmorDyeRecipeMixin` * new files - `common.block.cauldron.BedrockCauldronBehavior` - `common.block.entity.WaterCauldronBlockEntity` - `common.block.ColoredWaterCauldronBlock` - `common.features.cauldron.BedrockCauldronBlocks` - `assets/blockstates/colored_water_cauldron.json`
This allows to keep the Potion fluid in Cauldron. * new particle receiver has registered in `BedrockifyClient` - for the behavior of Potion-filled Cauldron * add block definition in `BedrockCauldronBlocks` - `PotionCauldronBlock` * update `BedrockCauldronBehavior.java` - add behavior of potions * registered mixins - `mixin.common.features.cauldron.CauldronBehaviorMixin` - `mixin.common.features.cauldron.LeveledCauldronBlockAccessor` - `mixin.common.features.cauldron.MinecraftServerMixin` * new files - `common.block.AbstractBECauldronBlock` - `common.block.PotionCauldronBlock` - `assets/blockstates/potion_cauldron.json`
* update dependencies - sodium mc1.19.3-0.4.9 * registered mixin - `mixin.client.compat.sodium.LinearColorBlenderMixin`
* update `AbstractBECauldronBlock`
* update `BedrockCauldronBehavior`
Set the loot table and block tag. * new files - `data/bedrockify/loot_tables/blocks/colored_water_cauldron.json` - `data/bedrockify/loot_tables/blocks/potion_cauldron.json` - `data/minecraft/tags/blocks/cauldrons.json`
Fabric API has some useful event listeners. * removed mixin - `mixin.common.features.cauldron.MinecraftServerMixin` * update files - `Bedrockify.java` - `BedrockifyClient.java`
Hello! So sorry for the looong time to respond. I've been testing and seems to be working great. Thank you for this clean implementation and detailed description. Awesome work!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please wait a moment while I
playtest on my 1.19.4-pre1 fabric server... Looks goodresolve #176
Important: Supports for Minecraft 1.19.4, not compatible with 1.19.3.
This allows to color the cauldron filled with water and dye the item by it, and to keep the Potion fluid.
New configurable option
bedrockCauldron
is available, and I haven’t added it to SettingsGUI. Please checkBedrockifySettings.java
.I tried to describe the changes and it got long, so I collapsed it. Click to expand.
Behavior...
The Behavior from Bedrock Edition is Implemented
Empty Cauldron
Water Cauldron
Colored Water Cauldron
Potion Cauldron
The Default Behavior from Java Edition is Retained
Recipes
Known Issues...
Different types of items can be stored in the cauldron, as long as they are of the same potion type. e.g. Fire Resistance and then Lingering Fire Resistance.
In this case, the last stored item takes priority, so when all of the items are taken out with Glass Bottle, they will be Lingering Fire Resistance. This is the Bedrock specification.
Partially compatible with Extra Alchemy.
✅ Place the modded Potion fluid.
✅ Take out the modded Potion fluid.
✅ Launch without this mod while keeping the modded Potion fluid; appears black.
✅ Re-install this and take out the modded Potion fluid without errors.
❌ Empty the modded Potion container and get this. This case is an Empty Vial. That’s because the Potion Cauldron can only interact with the Glass Bottle, but if you take out the fluid with the Glass Bottle, it will be a Breakable Potion. The only exception is the Breakable Water Bottle; the Cauldron becomes a Water Cauldron (not a Potion fluid) and you get a Glass Bottle. It cannot be undone.
Changes...
update dependencies
new configurable option in
BedrockifySettings
bedrockCauldron
new event callbacks have been registered in
BedrockifyClient
ColoredWaterCauldronBlock
andPotionCauldronBlock
registered mixins
mixin.client.compat.sodium.LinearColorBlenderMixin
mixin.common.features.cauldron.AbstractCauldronBlockMixin
mixin.common.features.cauldron.ArmorDyeRecipeMixin
mixin.common.features.cauldron.CauldronBehaviorMixin
mixin.common.features.cauldron.LeveledCauldronBlockAccessor
mixin.common.features.cauldron.MinecraftServerMixin
new files
common.block.cauldron.BedrockCauldronBehavior
common.block.entity.WaterCauldronBlockEntity
common.block.AbstractBECauldronBlock
common.block.ColoredWaterCauldronBlock
common.block.PotionCauldronBlock
common.features.cauldron.BedrockCauldronBlocks
assets/blockstates/colored_water_cauldron.json
assets/blockstates/potion_cauldron.json