Salvador cuellar #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjoms
requested changes
Jan 31, 2019
| console.log(x); | ||
| } | ||
|
|
||
| let agregar = (framework) => { |
There was a problem hiding this comment.
Parameters should always have a type, Typescript only infers a type when a variable is declared and assigned, so if we don't specify the type on parameters, the type will be 'any'.
| <input type="text" class="form-control prueba" placeholder="Framework"> | ||
| </div> | ||
| <div class="col-3"> | ||
| <input type="text" class="form-control prueba2" placeholder="Descripcion" value=""> |
There was a problem hiding this comment.
Let's use more meaningful id/class names, for example 'input-description' instead of 'pruebaX'
Also, is a better practice to use ids on input forms since in most of the cases the elements on a form are unique.
| } | ||
|
|
||
|
|
||
| let prueba = () => { |
There was a problem hiding this comment.
- When a variable or method is not going to be reassigned, is a better practice to use
constinstead oflet. - Let's use more meaningful method names, e.g.
addFramework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ejercicio terminado sin searchbar