Added support for ExpressPay and EcobankPay EMV QR codes and fixed some validation issues. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brutaldev
commented
Oct 18, 2019
brutaldev
commented
- Added test for 5 live EMV QR codes that failed to be parsed but are actually valid.
- Fixed merchant information tag ID range validation, it can be from 2 to 51 and it's even extracted in that range.
- Fixed validation failures when there is no additional data or merchant language template (both are optional).
- Fixed Issue Breaks when using EcoBank QR Codes (EMV compliant) #2 by checking there is available length to substring before attempting it.
- Fixed some code analysis warnings.
- Assume if the merchant information has no child nodes (not a child TLV) then the Globally Unique Identifier IS the string, this sis the case for Visa and MasterCard PAN/Alias/Card Numbers present in actual EMV QR codes.
…me validation issues. - Added test for 5 live EMV QR codes that failed to be parsed but are actually valid. - Fixed merchant information tag ID range validation, it can be from 2 to 51 and it's even extracted in that range. - Fixed validation failures when there is no additional data or merchant language template (both are optional). - Fixed Issue juanroman-zz#2 by checking there is available length to substring before attempting it. - Fixed some code analysis warnings. - Assume if the merchant information has no child nodes (not a child TLV) then the Globally Unique Identifier IS the string, this sis the case for Visa and MasterCard PAN/Alias/Card Numbers present in actual EMV QR codes. Issue juanroman-zz#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.