Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks when using EcoBank QR Codes (EMV compliant) #2

Open
brutaldev opened this issue Oct 15, 2019 · 0 comments
Open

Breaks when using EcoBank QR Codes (EMV compliant) #2

brutaldev opened this issue Oct 15, 2019 · 0 comments

Comments

@brutaldev
Copy link

The TLV parsing breaks with an ArgumentOutOfRangeException when using EcoBank codes. There are EMV compliant codes as far as I know.

Here is an example code that breaks: 0002010102110213404587568745904155326311155509945204625353039365802GH5915MAXMART LIMITED6005ACCRA62240708620037450308620037456304C913

The code has parent tags but there doesn't seem to be child information associated with it so the parse call length is wrong.

brutaldev pushed a commit to brutaldev/emvqr that referenced this issue Oct 18, 2019
…me validation issues.

- Added test for 5 live EMV QR codes that failed to be parsed but are actually valid.
- Fixed merchant information tag ID range validation, it can be from 2 to 51 and it's even extracted in that range.
- Fixed validation failures when there is no additional data or merchant language template (both are optional).
- Fixed Issue juanroman-zz#2 by checking there is available length to substring before attempting it.
- Fixed some code analysis warnings.
- Assume if the merchant information has no child nodes (not a child TLV) then the Globally Unique Identifier IS the string, this sis the case for Visa and MasterCard PAN/Alias/Card Numbers present in actual EMV QR codes.

Issue juanroman-zz#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant