-
-
Notifications
You must be signed in to change notification settings - Fork 355
Added support for X-CSRF-Token header acceptance. #180
Added support for X-CSRF-Token header acceptance. #180
Conversation
@@ -4,16 +4,20 @@ | |||
class PostTest < Test::Unit::TestCase | |||
# Make sure you have a posttest.localhost in your /etc/hosts/ | |||
def setup | |||
@url='http://posttest.localhost:10453/' | |||
@url='http://localhost:10453/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why'd you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the subdomain piece caused the specs to all error out locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is caused by the version bump from 0.2.4
to 1.0.0
?
Edit: not the case.
Thanks! Looks good to me. Before I merge, what were the failures on a fresh checkout? I'm getting 100% pass when I run it:
|
@pickhardt a fresh checkout using Ruby 2.4.0 has a number of issues for me:
Dropping line 2 of the Gemfile addresses that. But, then standing up the
I'm on Ruby 2.4.0 and wondering if the issues I'm seeing are due to MRI versioning. I'd be more than happy to try and improve compatibility issues like these though. |
Can you install s3cmd and boto if you don't already have them? (https://github.com/jubos/fake-s3/blob/master/CONTRIBUTING.md#testing) I think you also found some valid warnings, like |
The tests added by this PR pass. There were multiple failures on a fresh checkout, and we didn't fix those.