Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Added support for X-CSRF-Token header acceptance. #180

Merged
merged 1 commit into from Jan 26, 2017
Merged

Added support for X-CSRF-Token header acceptance. #180

merged 1 commit into from Jan 26, 2017

Conversation

plainprogrammer
Copy link
Contributor

The tests added by this PR pass. There were multiple failures on a fresh checkout, and we didn't fix those.

pickhardt
pickhardt reviewed Jan 24, 2017
View reviewed changes
test/post_test.rb
@@ -4,16 +4,20 @@
class PostTest < Test::Unit::TestCase
# Make sure you have a posttest.localhost in your /etc/hosts/
def setup
@url='http://posttest.localhost:10453/'
@url='http://localhost:10453/'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why'd you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the subdomain piece caused the specs to all error out locally.

Copy link

@aefhm aefhm Jan 24, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is caused by the version bump from 0.2.4 to 1.0.0?

Edit: not the case.

@pickhardt
Copy link
Collaborator

Thanks! Looks good to me. Before I merge, what were the failures on a fresh checkout? I'm getting 100% pass when I run it:

Finished in 9.017251 seconds.
------------------------------------------------------------------
33 tests, 46 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------
3.66 tests/s, 5.10 assertions/s

@plainprogrammer
Copy link
Contributor Author

plainprogrammer commented Jan 24, 2017 •
edited

@pickhardt a fresh checkout using Ruby 2.4.0 has a number of issues for me:

Your Gemfile lists the gem fakes3 (>= 0) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of one of them later.

[!] There was an error parsing `Gemfile`: You cannot specify the same gem twice coming from different sources.
You specified that fakes3 (>= 0) should come from source at `.` and source at `.`
. Bundler cannot continue.

 #  from /Users/mavenlink/workspace/fake-s3/Gemfile:4
 #  -------------------------------------------
 #  # Specify your gem's dependencies in fakes3.gemspec
 >  gemspec
 #  -------------------------------------------

Dropping line 2 of the Gemfile addresses that. But, then standing up the rake test_server and running rake test yields the following for me:

/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/site_ruby/2.4.0/rubygems/specification.rb:2508: warning: constant ::Fixnum is deprecated
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/site_ruby/2.4.0/rubygems/specification.rb:2508: warning: constant ::Fixnum is deprecated
/Users/mavenlink/workspace/fake-s3/lib/fakes3/file_store.rb:153: warning: assigned but unused variable - src_obj
/Users/mavenlink/workspace/fake-s3/lib/fakes3/server.rb:486: warning: ambiguous first argument; put parentheses or a space even after `/' operator
/Users/mavenlink/workspace/fake-s3/lib/fakes3/errors.rb:9: warning: `*' interpreted as argument prefix
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:24: warning: assigned but unused variable - res
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:36: warning: assigned but unused variable - res
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:47: warning: assigned but unused variable - res
/Users/mavenlink/workspace/fake-s3/test/right_aws_commands_test.rb:33: warning: assigned but unused variable - obj
/Users/mavenlink/workspace/fake-s3/test/right_aws_commands_test.rb:93: warning: assigned but unused variable - obj
/Users/mavenlink/workspace/fake-s3/test/right_aws_commands_test.rb:143: warning: assigned but unused variable - bucket
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/right_http_connection.rb:288: warning: assigned but unused variable - e
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/right_http_connection.rb:340: warning: assigned but unused variable - msg
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:50: warning: method redefined; discarding old rbuf_fill
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/protocol.rb:171: warning: previous definition of rbuf_fill was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:81: warning: method redefined; discarding old exec
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/http/generic_request.rb:119: warning: previous definition of exec was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:93: warning: method redefined; discarding old send_request_with_body
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/http/generic_request.rb:182: warning: previous definition of send_request_with_body was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:101: warning: method redefined; discarding old send_request_with_body_stream
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/http/generic_request.rb:191: warning: previous definition of send_request_with_body_stream was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:145: warning: method redefined; discarding old request
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/http.rb:1405: warning: previous definition of request was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/awsbase/benchmark_fix.rb:29: warning: method redefined; discarding old add!
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/benchmark.rb:443: warning: previous definition of add! was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/awsbase/right_awsbase.rb:509: warning: shadowing outer local variable - response
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/awsbase/right_awsbase.rb:29: warning: constant OpenSSL::Digest::Digest is deprecated
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/awsbase/right_awsbase.rb:32: warning: constant OpenSSL::Digest::Digest is deprecated
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/awsbase/right_awsbase.rb:593: warning: method redefined; discarding old last_request_id
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/ec2/right_ec2_instances.rb:274: warning: mismatched indentations at 'end' with 'def' at 270
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/ec2/right_ec2_security_groups.rb:103: warning: assigned but unused variable - list
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/ec2/right_ec2_vpc2.rb:380: warning: mismatched indentations at 'end' with 'class' at 26
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/s3/right_s3_interface.rb:205: warning: mismatched indentations at 'end' with 'def' at 181
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/s3/right_s3.rb:493: warning: shadowing outer local variable - key
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/sqs/right_sqs_interface.rb:409: warning: assigned but unused variable - m
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/sdb/right_sdb_interface.rb:24: warning: loading in progress, circular require considered harmful - /Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/right_aws.rb
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in  `<main>'
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:4:in  `select'
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:15:in  `block in <main>'
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@global/gems/rake-12.0.0/lib/rake/rake_test_loader.rb:15:in  `require'
	from /Users/mavenlink/workspace/fake-s3/test/right_aws_commands_test.rb:4:in  `<top (required)>'
	from /Users/mavenlink/workspace/fake-s3/test/right_aws_commands_test.rb:4:in  `require'
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/right_aws.rb:65:in  `<top (required)>'
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/right_aws.rb:65:in  `require'
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/sdb/right_sdb_interface.rb:24:in  `<top (required)>'
	from /Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/sdb/right_sdb_interface.rb:24:in  `require'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/acf/right_acf_interface.rb:146: warning: mismatched indentations at 'end' with 'def' at 122
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/rds/right_rds_interface.rb:1656: warning: mismatched indentations at 'end' with 'class' at 26
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_aws-3.1.0/lib/route_53/right_route_53_interface.rb:226: warning: mismatched indentations at 'end' with 'def' at 202
Loaded suite /Users/mavenlink/.rvm/gems/ruby-2.4.0@global/gems/rake-12.0.0/lib/rake/rake_test_loader
Started
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/credential_providers.rb:450: warning: assigned but unused variable - e
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/client.rb:786: warning: shadowing outer local variable - xml
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/client.rb:864: warning: shadowing outer local variable - xml
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/client.rb:1047: warning: shadowing outer local variable - xml
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/client.rb:1659: warning: shadowing outer local variable - xml
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/client.rb:211: warning: assigned but unused variable - pauses
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/region_detection.rb:36: warning: assigned but unused variable - bucket
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/region_detection.rb:56: warning: assigned but unused variable - bucket
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/client.rb:66: warning: method redefined; discarding old sign_request
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/client.rb:700: warning: previous definition of sign_request was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/bucket.rb:625: warning: assigned but unused variable - e
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/acl_options.rb:129: warning: possibly useless use of a literal in void context
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/s3_object.rb:274: warning: assigned but unused variable - e
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/s3_object.rb:917: warning: assigned but unused variable - resp
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/s3_object.rb:1399: warning: assigned but unused variable - threshold
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:57: warning: assigned but unused variable - secret
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:107: warning: method redefined; discarding old port
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/credential_providers.rb:50: warning: instance variable @cached_credentials not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/xml/frame.rb:98: warning: assigned but unused variable - map
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
./Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/credential_providers.rb:50: warning: instance variable @cached_credentials not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
./Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/credential_providers.rb:50: warning: instance variable @cached_credentials not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/multipart_upload.rb:76: warning: assigned but unused variable - e
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/multipart_upload.rb:320: warning: method redefined; discarding old inspect
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/multipart_upload.rb:52: warning: previous definition of inspect was here
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/s3/multipart_upload.rb:134: warning: instance variable @aborted not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/signers/s3.rb:60:in `signature': warning: URI.escape is obsolete
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/async_handle.rb:85: warning: instance variable @_async_callbacks not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/response.rb:42: warning: instance variable @network_error not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:193: warning: instance variable @body_stream not initialized
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/aws-sdk-v1-1.66.0/lib/aws/core/http/request.rb:195: warning: instance variable @body not initialized
../Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
./Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
F
======================================================================
Failure: test_redirect(PostTest)
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:30:in `block in test_redirect'
     27:       'success_action_redirect'=>'http://somewhere.else.com/',
     28:       'file'=>File.new(__FILE__,"rb")
     29:     ) { |response|
  => 30:       assert_equal(response.code, 307)
     31:       assert_equal(response.headers[:location], 'http://somewhere.else.com/')
     32:     }
     33:   end
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:858:in `process_result'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:776:in `block in transmit'
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/http.rb:877:in `start'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:766:in `transmit'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:215:in `execute'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:52:in `execute'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient.rb:71:in `post'
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:24:in `test_redirect'
<500> expected but was
<307>

diff:
? 500
? 3 7
======================================================================
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
F
======================================================================
Failure: test_status_200(PostTest)
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:42:in `block in test_status_200'
     39:       'success_action_status'=>'200',
     40:       'file'=>File.new(__FILE__,"rb")
     41:     ) { |response|
  => 42:       assert_equal(response.code, 200)
     43:     }
     44:   end
     45:
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:858:in `process_result'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:776:in `block in transmit'
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/http.rb:877:in `start'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:766:in `transmit'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:215:in `execute'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:52:in `execute'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient.rb:71:in `post'
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:36:in `test_status_200'
<500> expected but was
<200>

diff:
? 500
? 2
======================================================================
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
F
======================================================================
Failure: test_status_201(PostTest)
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:53:in `block in test_status_201'
     50:       'success_action_status'=>'201',
     51:       'file'=>File.new(__FILE__,"rb")
     52:     ) { |response|
  => 53:       assert_equal(response.code, 201)
     54:       assert_match(%r{^\<\?xml.*uploads/12345/post_test\.rb}m, response.body)
     55:     }
     56:   end
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:858:in `process_result'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:776:in `block in transmit'
/Users/mavenlink/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/net/http.rb:877:in `start'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:766:in `transmit'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:215:in `execute'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient/request.rb:52:in `execute'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/rest-client-2.0.0/lib/restclient.rb:71:in `post'
/Users/mavenlink/workspace/fake-s3/test/post_test.rb:47:in `test_status_201'
<500> expected but was
<201>

diff:
? 500
? 2 1
======================================================================
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/right_http_connection-1.5.0/lib/base/net_fix.rb:51:in `rbuf_fill': Object#timeout is deprecated, use Timeout.timeout instead.
## ^^ This warning got repeated a lot!

.E
======================================================================
Error: test_acl(S3CmdTest): RuntimeError: Please install s3cmd
/Users/mavenlink/workspace/fake-s3/test/s3cmd_test.rb:7:in `setup'
======================================================================
E
======================================================================
Error: test_create_bucket(S3CmdTest): RuntimeError: Please install s3cmd
/Users/mavenlink/workspace/fake-s3/test/s3cmd_test.rb:7:in `setup'
======================================================================
E
======================================================================
Error: test_intra_bucket_copy(S3CmdTest): RuntimeError: Please install s3cmd
/Users/mavenlink/workspace/fake-s3/test/s3cmd_test.rb:7:in `setup'
======================================================================
E
======================================================================
Error: test_large_store(S3CmdTest): RuntimeError: Please install s3cmd
/Users/mavenlink/workspace/fake-s3/test/s3cmd_test.rb:7:in `setup'
======================================================================
E
======================================================================
Error: test_multi_directory(S3CmdTest): RuntimeError: Please install s3cmd
/Users/mavenlink/workspace/fake-s3/test/s3cmd_test.rb:7:in `setup'
======================================================================
E
======================================================================
Error: test_store(S3CmdTest): RuntimeError: Please install s3cmd
/Users/mavenlink/workspace/fake-s3/test/s3cmd_test.rb:7:in `setup'
======================================================================


Finished in 16.472891 seconds.
----------------------------------------------------------------------
27 tests, 38 assertions, 3 failures, 6 errors, 0 pendings, 0 omissions, 0 notifications
66.6667% passed
----------------------------------------------------------------------
1.64 tests/s, 2.31 assertions/s
rake aborted!
Command failed with status (1)
/Users/mavenlink/.rvm/gems/ruby-2.4.0@global/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/cli/exec.rb:74:in `load'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/cli/exec.rb:74:in `kernel_load'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/cli/exec.rb:27:in `run'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/cli.rb:335:in `exec'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/cli.rb:20:in `dispatch'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/cli.rb:11:in `start'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/exe/bundle:32:in `block in <top (required)>'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/gems/bundler-1.14.3/exe/bundle:24:in `<top (required)>'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/bin/bundle:23:in `load'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/bin/bundle:23:in `<main>'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/bin/ruby_executable_hooks:15:in `eval'
/Users/mavenlink/.rvm/gems/ruby-2.4.0@fakes3/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => test
(See full trace by running task with --trace)

I'm on Ruby 2.4.0 and wondering if the issues I'm seeing are due to MRI versioning. I'd be more than happy to try and improve compatibility issues like these though.

@pickhardt
Copy link
Collaborator

Can you install s3cmd and boto if you don't already have them? (https://github.com/jubos/fake-s3/blob/master/CONTRIBUTING.md#testing)

I think you also found some valid warnings, like Object#timeout is deprecated I know, this should get updated. I want to both update that and also work down the issues and PRs. (Have been making some progress recently)

@pickhardt pickhardt merged commit 745820b into jubos:master Jan 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pickhardt pickhardt pickhardt left review comments

@aefhm aefhm aefhm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plainprogrammer @pickhardt @aefhm